Repository navigation
fix(ffi): restore build of regorus_program_get_builtin_names - #864
Merged
Anand Krishnamoorthi (anakrish) merged 1 commit intoOct 26, 2026
Conversation
microsoft#853 added a call to `to_rvm_string_result`, while microsoft#830 removed that helper as unused. The two merged concurrently, leaving main's FFI crate unbuildable (`cannot find function to_rvm_string_result`), which also breaks `cargo xtask clippy` and the pre-commit hook. Use the shared `common::to_regorus_string_result` instead. The closure can only fail with null/invalid-handle or serde errors, never `VmError`, so the returned status (`RegorusStatus::Error`) is unchanged from the removed helper's behavior for this path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Anand Krishnamoorthi (anakrish)
approved these changes
Oct 26, 2026
Anand Krishnamoorthi (anakrish)
merged commit Oct 26, 2026
b5247ea
into
microsoft:main
60 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#853 added a call to
to_rvm_string_result, while #830 removed that helper as unused. The two merged concurrently, leaving main's FFI crate unbuildable (cannot find function to_rvm_string_result), which also breakscargo xtask clippyand the pre-commit hook.Use the shared
common::to_regorus_string_resultinstead. The closure can only fail with null/invalid-handle or serde errors, neverVmError, so the returned status (RegorusStatus::Error) is unchanged from the removed helper's behavior for this path.