Repository navigation
feat: add default-off explanations cargo feature - #873
Merged
Anand Krishnamoorthi (anakrish) merged 2 commits intoOct 28, 2026
Merged
Anand Krishnamoorthi (anakrish) merged 2 commits into
Anand Krishnamoorthi (anakrish) merged 2 commits into
Conversation
Add the `explanations` feature (implies `rvm`) and an empty, feature-gated `regorus::explain` module as the landing point for causality reports and partial evaluation. No functionality yet. CI coverage: `cargo xtask ci-*` checks the `std,arc,explanations` feature combination. Clippy and `--all-features` builds already cover it. A dedicated test step will be added once the module has code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Anand Krishnamoorthi (anakrish)
approved these changes
Oct 28, 2026
Anand Krishnamoorthi (anakrish)
merged commit Oct 28, 2026
c32915c
into
microsoft:main
60 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First PR in the series that splits #835 (causality reporting + partial evaluation) into small reviewable pieces. This one only adds the feature flag; it has no functionality.
explanationscargo feature. Default off and impliesrvm. Explanations are produced by the RVM only.regorus::explainmodule. Feature-gated, with adocsrsannotation. Later PRs add the report types, provenance, tracing, and partial evaluation here.cargo xtask ci-*checks thestd,arc,explanationsfeature combination. Clippy and--all-featuresbuilds already cover the feature.Builds without the feature are unchanged.
Note:
rvmneedsstdandarcwithout declaring them (this is already the case on main), soexplanationshas the same requirement for now.Testing
Validated with Rust 1.95.0:
cargo fmt --check--all-featuresand with--no-default-features--no-default-features,--features explanations, andstd,arc,explanationscargo test --features explanations --libDependencies: none (based on main).