[Eric Del Orefice (ericdelorefice)]

Motivation and Context

RedisCollection.collection_exists caught every exception and returned False, and ensure_collection_deleted gates the drop on that answer:

async def ensure_collection_deleted(self, **kwargs) -> None:
    exists = await self.collection_exists()
    if exists:
        await self.redis_database.ft(self.collection_name).dropindex(**kwargs)
    else:
        logger.debug("Collection does not exist, skipping deletion.")

collection_exists() reaches Redis to answer, so a timeout, an authentication failure or an unreachable node all return False. ensure_collection_deleted then logs at debug level and returns normally, and the caller is told the collection is gone when it is still there.

The ChromaCollection connector already draws this distinction - it handles a genuinely absent collection quietly and raises VectorStoreOperationException for anything else. This brings the Redis connector in line with it.

Fixes #14473

Description

collection_exists now catches ResponseError, which is what redis-py raises when FT.INFO reports an unknown index. ConnectionError, TimeoutError and AuthenticationError are siblings of ResponseError rather than subclasses, so they propagate instead of being reported as an absent index.

On the test change: test_collection_exists_false used a bare Exception as the side effect. Redis does not raise that, and it matched a timeout as readily as a missing index, so the test could not tell the two cases apart. It now raises ResponseError, which is the real behaviour, and a new test asserts that a connection error reaches the caller.

I checked that the new test fails without the source change, so it is testing what it claims to.

Contribution Checklist

• The code builds clean without any errors or warnings
• I didn't break anyone 😄
• I have added tests that prove my fix is effective
• All unit tests pass locally: pytest tests/unit/connectors/memory/test_redis_store.py passes 27/27

[Eric Del Orefice (ericdelorefice)]

@microsoft-github-policy-service agree

[Copilot]

Copilot review overview

🟡 Changes recommended

Redis imports are incorrectly ordered in both reviewed files and will fail configured Ruff checks.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2

Open (2)

• Fix redis import order to satisfy Ruff isort checks · New
• Group redis.exceptions imports with other third-party imports · New

What changed in this PR

This pull request ensures Redis connection failures are not reported as missing indexes.

Changes:

• Handles ResponseError for missing indexes.
• Adds tests for connection-error propagation.

File	Summary
python/​semantic_kernel/​connectors/​redis.py	Updates Redis index existence error handling.
python/​tests/​unit/​connectors/​memory/​test_redis_store.py	Adds targeted exception tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Eric Del Orefice (ericdelorefice)]

Good catch on both, and you are right. Fixed and pushed.

redis.exceptions sorts after redis.commands, so the connector import was in the wrong place within the third-party group, and in the test file the two new imports split the third-party block from the semantic_kernel one. Ruff's isort gate is enabled in python/pyproject.toml, so both would have failed lint rather than merely looking untidy.

ruff check and ruff format --check now pass on both files, and pytest tests/unit/connectors/memory/test_redis_store.py still passes 27/27.

One correction on the report itself: the second instance is at line 20 of the test file, not line 291 of the connector. Line 291 is the collection_exists change, which has no import in it.