Skip to content

Python: Docs/python connector extras - #14505

Open
S.J. (cstolting-collab) wants to merge 7 commits into
microsoft:mainfrom
cstolting-collab:docs/python-connector-extras
Open

S.J. (cstolting-collab) wants to merge 7 commits into
microsoft:mainfrom
cstolting-collab:docs/python-connector-extras

Conversation

@cstolting-collab

Copy link
Copy Markdown
Contributor

Motivation and Context

Description

Contribution Checklist

Copilot AI balanced review requested due to automatic review settings September 29, 2026 21:02
@cstolting-collab
S.J. (cstolting-collab) requested a review from a team as a code owner September 29, 2026 21:02
@semantic-kernel-automation semantic-kernel-automation Bot added python Pull requests for the Python Semantic Kernel documentation labels Sep 29, 2026
@github-actions github-actions Bot changed the title Docs/python connector extras Python: Docs/python connector extras Sep 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Two dependency entries are incomplete, and the synchronization test does not detect stale extras.

Review effort: Balanced
Findings: 1 Medium severity · 2 Low severity

Open (3)
What changed in this PR

Adds centralized documentation for Python connector extras and links it from the Python README.

Changes:

  • Documents base and optional connector dependencies.
  • Adds a synchronization test for extra names.
  • Links the dependency matrix from installation guidance.
File Description
python/​CONNECTOR_DEPENDENCIES.md Adds the connector dependency matrix.
python/​README.md Links to the new matrix.
python/​tests/​unit/​test_connector_extras_documentation.py Checks documented extra names.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread python/CONNECTOR_DEPENDENCIES.md Resolved
Comment thread python/CONNECTOR_DEPENDENCIES.md Resolved
@eavanvalkenburg

Copy link
Copy Markdown
Member

All three earlier findings are fixed, and the documentation regression test passes. Fresh validation is still required: the current-head workflows failed before creating their validation jobs, so the two successful checks do not represent passing Python/build/spelling validation. The failed workflows were created on September 29 and are beyond the GitHub rerun limit. Please update/rebase onto current main, refresh any dependency ranges changed there, and let fresh workflows run.

Merge microsoft/semantic-kernel main at 05b6569 into the existing PR branch, preserving its history.

Refresh the documented google-genai, mistralai, onnxruntime-genai,
qdrant-client and websockets ranges from the merged pyproject.toml.
Remove an extra blank line rejected by the pinned Ruff import check.

Local validation on Python 3.12.14:
- Existing documentation regression: 1 passed, run in isolation with
  --noconftest -c /dev/null; this is not the full Python unit suite.
- All 26 optional extras and 43 requirement entries match package metadata.
- Ruff 0.9.6 lint and format checks pass for the changed test.
- Typos 1.44.0 passes for the three PR files using the repository config.
- Python sdist and wheel build successfully with build 1.6.1 and flit-core 3.12.0.
- git diff --check passes.

Fresh GitHub workflow results remain separate from these local checks.

This branch was successfully deployed

1 active deployment
github-app-auth — 04fbb58f Deployed Nov 3, 2026 by cstolting-collab via add_label #29579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants