Repository navigation
Python: Fix VolatileMemoryStore.get_nearest_match returning an un-awaited coroutine - #14523
Open
PRABHU KIRAN VANDRANKI (VANDRANKI) wants to merge 1 commit into
Conversation
PRABHU KIRAN VANDRANKI (VANDRANKI)
requested a review
from a team
as a code owner
October 1, 2026 16:56
PRABHU KIRAN VANDRANKI (VANDRANKI)
temporarily deployed
to
github-app-auth
October 1, 2026 16:56 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
PRABHU KIRAN VANDRANKI (VANDRANKI)
temporarily deployed
to
github-app-auth
October 1, 2026 16:57 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
semantic-kernel-automation
Bot
added
the
python
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix matches established implementations and is covered by targeted regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes VolatileMemoryStore.get_nearest_match to return the nearest record and score instead of an un-awaited coroutine.
Changes:
- Awaits
get_nearest_matchesand returns its first result. - Adds regression tests for tuple results and relevance thresholds.
| File | Description |
|---|---|
python/semantic_kernel/memory/volatile_memory_store.py |
Corrects asynchronous result handling. |
python/tests/unit/memory/test_volatile_memory_store.py |
Adds regression coverage for nearest-match behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
4 tasks done
Member
|
The coroutine fix and both regression tests pass in review. This PR now has merge conflicts, and the current head has no completed Python validation jobs. Please rebase onto current main and rerun CI before this can be approved and queued. |
Anton Dziatkovskii (tonydzi)
pushed a commit
to tonydzi/semantic-kernel
that referenced
this pull request
Nov 2, 2026
…ction (microsoft#14536) ### Motivation and Context `VolatileMemoryStore.get_nearest_matches` raises `ValueError: cannot reshape array of size 0 into shape (0,newaxis)` when the collection exists but has no records. A search on a new or emptied collection should return no results, as it already does for a missing collection. Fixes microsoft#14534 ### Description Return `[]` early when the collection has no records, before the embeddings are stacked and reshaped. Added two tests: a freshly created collection, and a collection whose only record was removed. Both fail on `main` with the ValueError and pass with the fix. The tests are in a new file to avoid touching the files used by open PRs microsoft#14523 and microsoft#14524. Checks: ruff format and check clean, mypy clean on the changed file. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
VolatileMemoryStore.get_nearest_matchisasync defbut returnedself.get_nearest_matches(...)without awaiting it, so callers received a coroutine instead of a(MemoryRecord, score)tuple. Fixes #14521.Description
Await
get_nearest_matchesand return its first element, the same wayChromaMemoryStore.get_nearest_matchdoes. Addedtests/unit/memory/test_volatile_memory_store.pywith two tests. Both fail on main (they receive a coroutine) and pass with the change.Contribution Checklist