Repository navigation
.Net: Remove migrated .NET Milvus connector - #14682
Merged
Adam Sitnik (adamsitnik) merged 1 commit intoOct 30, 2026
Merged
Conversation
Remove the legacy Milvus memory store and tests now that the VectorData provider is available in CommunityToolkit/AI. Point users to the published package and remove unused dependencies and the empty MEVD solution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adam Sitnik (adamsitnik)
deployed
to
github-app-auth
October 29, 2026 17:56 — with
GitHub Actions
Active
Adam Sitnik (adamsitnik)
deployed
to
integration
October 29, 2026 17:56 — with
GitHub Actions
Active
Adam Sitnik (adamsitnik)
marked this pull request as ready for review
October 30, 2026 08:24
Adam Sitnik (adamsitnik)
requested review from
Shay Rojansky (roji) and
westey (westey-m)
and
a balanced review from Copilot
October 30, 2026 08:24
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the legacy Milvus connector removal.
No open issues 🎉
What changed in this PR
Removes the legacy .NET Milvus connector following its migration to CommunityToolkit/AI, continuing the cleanup started with the Chroma connector in #14579.
Changes:
- Deletes the Milvus memory-store implementation, test project, and associated tests.
- Replaces the README with a deprecation notice linking to the CommunityToolkit package and implementation.
- Removes unused dependencies, the experimental-feature entry, and the now-empty
MEVD.slnx.
| File | Description |
|---|---|
dotnet/test/VectorData/Milvus.UnitTests/MilvusMemoryStoreTests.cs |
Removes memory-store integration tests. |
dotnet/test/VectorData/Milvus.UnitTests/MilvusLegacyServerTests.cs |
Removes legacy-server compatibility tests. |
dotnet/test/VectorData/Milvus.UnitTests/MilvusFixture.cs |
Removes the Milvus container fixture. |
dotnet/test/VectorData/Milvus.UnitTests/MilvusFilterTests.cs |
Removes ID-filter and server-version tests. |
dotnet/test/VectorData/Milvus.UnitTests/Milvus.UnitTests.csproj |
Deletes the Milvus test project. |
dotnet/src/VectorData/Milvus/README.md |
Directs users to the CommunityToolkit replacement. |
dotnet/src/VectorData/Milvus/MilvusMemoryStore.cs |
Deletes the legacy memory-store implementation. |
dotnet/src/VectorData/Milvus/Milvus.csproj |
Deletes the connector project. |
dotnet/src/VectorData/Milvus/AssemblyInfo.cs |
Removes the connector’s experimental annotation. |
dotnet/src/IntegrationTests/IntegrationTests.csproj |
Removes the unused Milvus test-container dependency. |
dotnet/src/Experimental/Process.IntegrationTestRunner.Dapr/Process.IntegrationTestRunner.Dapr.csproj |
Removes the unused Milvus test-container dependency. |
dotnet/MEVD.slnx |
Deletes the solution after removing its remaining projects. |
dotnet/docs/EXPERIMENTS.md |
Removes the Milvus experimental-feature listing. |
dotnet/Directory.Packages.props |
Removes central Milvus package versions. |
Review effort: Balanced
Shay Rojansky (roji)
approved these changes
Oct 30, 2026
Adam Sitnik (adamsitnik)
enabled auto-merge
October 30, 2026 08:36
westey (westey-m)
approved these changes
Oct 30, 2026
Adam Sitnik (adamsitnik)
deleted the
copilot/remove-migrated-milvus-connector
branch
October 30, 2026 11:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow the Chroma cleanup in #14579 now that the Milvus provider has merged in CommunityToolkit/AI#77 and is published as CommunityToolkit.VectorData.Milvus.
Description
MEVD.slnx, which has no projects left after this removal.Validation:
git diff --check— passed.dotnet msbuild dotnet/src/IntegrationTests/IntegrationTests.csproj -getItem:PackageReference -verbosity:quiet— passed; evaluated package references contain no Milvus dependency.dotnet msbuild dotnet/src/Experimental/Process.IntegrationTestRunner.Dapr/Process.IntegrationTestRunner.Dapr.csproj -getItem:PackageReference -verbosity:quiet— passed; evaluated package references contain no Milvus dependency.dotnet formatwere not run. The Milvus implementation and test project are removed; the remaining changes are documentation, solution, and dependency cleanup.Contribution Checklist