JoinableTaskContext.IsOnMainThread should satisfy VSTHRD010 #1100

Activity

1. zivkan commented on Oct 29, 2022

   

   Andy Zivkovic (zivkan)

   on Oct 29, 2022

   MemberAuthor

   More actions

   Here's some test code that I believe should be made to work:

           var test = @"
   using System.Threading.Tasks;
   using Microsoft.VisualStudio.Shell;
   using Microsoft.VisualStudio.Shell.Interop;
   using Task = System.Threading.Tasks.Task;
   
   class Test
   {
       void Foo()
       {
           ThreadHelper.ThrowIfNotOnUIThread();
           IVsSolution solution = Package.GetGlobalService(typeof(SVsSolution)) as IVsSolution;
       }
       async Task FirstAsync()
       {
           if (ThreadHelper.JoinableTaskFactory.Context.IsOnMainThread)
           {
               Foo(); // this generates a warning, even though Reset() doesn't assert
           }
       }
   }
   ";
           await CSVerify.VerifyAnalyzerAsync(test);

   However, I haven't yet been able to get the product code to make the test pass. I don't have any experience with the Roslyn APIs, so it's a learning curve to contribute. As much as I'd love to get my own name in the commit history, if someone else can get this implemented before me, I'll be happy to be able to take advantage of the improvement.
2. Andrew Arnott (AArnott)

   added

   enhancement

   analyzers

   on Oct 30, 2022