Forward non-source file change notifications - #14742
Draft
Sean McManus (sean-mcmanus) wants to merge 1 commit into
Draft
Forward non-source file change notifications#14742Sean McManus (sean-mcmanus) wants to merge 1 commit into
Sean McManus (sean-mcmanus) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
September 8, 2026 10:03
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unconditional synchronous file stats can block the extension host and fail when transient files disappear.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Forwards non-source file changes so the language service can invalidate translation units using resources such as #embed payloads.
Changes:
- Removes source-file filtering from change notifications.
- Retains modification-time suppression and editor configuration invalidation.
File summaries
| File | Description |
|---|---|
Extension/src/LanguageServer/client.ts |
Forwards recent changes for all workspace files. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // VS Code has a bug that causes onDidChange events to happen to files that aren't changed, | ||
| // which causes a large backlog of file notifications to accumulate. | ||
| // We workaround this via only sending the change message if the modified time is within 10 seconds. | ||
| const mtime: Date = fs.statSync(uri.fsPath).mtime; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward recent file-change notifications for non-source files to the language service so it can invalidate translation units that depend on resources such as C23/C++26
#embedpayloads. The language service determines whether each file is relevant, while the existing modification-time suppression continues to avoid duplicate notifications.Validation