Change default value of openPullLinks - #8942
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The runtime code currently hard-codes a true fallback for openPullLinks, which will override the new schema default and prevent the change from taking effect.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
package.json — Changing the schema default to false won't actually change the effective default at runtime:… |
What changed in this PR
Updates the extension’s contributed configuration to change the default behavior for opening GitHub issue/PR links inside VS Code.
Changes:
- Set
githubPullRequests.openPullLinksconfiguration default fromtruetofalse.
| File | Description |
|---|---|
| package.json | Changes the contributed configuration schema default for githubPullRequests.openPullLinks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is small, consistent across schema and runtime, and has a clear, contained behavioral impact.
Review tier: Lite
Findings: None
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
package.json — Changing the schema default to false won't actually change the effective default at runtime:… View resolved comment |
e38f3d0
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Test cleanup ordering can skip resource disposal if the settings restore throws, and user-facing release notes should be updated to match the new default.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
|
src/test/github/externalUriOpener.test.ts — In the finally block, configuration.update(...) is awaited before disposing the… |
 |
package.json — With githubPullRequests.openPullLinks now defaulting to false, the release note in CHANGELOG.md… |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The default change is consistently applied across runtime code, configuration schema, and the relevant test with proper cleanup.
Review tier: Lite
Findings: None
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
|
package.json — With githubPullRequests.openPullLinks now defaulting to false, the release note in CHANGELOG.md… View resolved comment |
|
src/test/github/externalUriOpener.test.ts — In the finally block, configuration.update(...) is awaited before disposing the… View resolved comment |
No description provided.