Skip to content

Fix agent host CLI output issues for Windows - #333376

Open
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
mainfrom
agents/fix-agent-host-cli-output-issues
Open

Fix agent host CLI output issues for Windows#333376
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
mainfrom
agents/fix-agent-host-cli-output-issues

Conversation

@dmitrivMS

@dmitrivMS Dmitriy Vasyura (dmitrivMS) commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

This pull request addresses several output issues in the Agent Host CLI on Windows, specifically related to improper character rendering and incorrect branding.

Changes include:

  • Updated the output formatting to use ASCII characters instead of Unicode for banners and symbols in output.rs, ensuring compatibility with Windows consoles.
  • Corrected the application name from code to code-insiders in agent_host.rs to reflect the correct branding.
  • Centralized the UTF-8/ASCII selection logic for all user-visible symbols across commands, including agent ps and agent logs.
  • Implemented detection of the terminal's UTF-8 support using GetConsoleOutputCP() to dynamically adjust output formatting.

All changes have been validated with passing tests and proper formatting.

Fixes #333375

Copilot AI balanced review requested due to automatic review settings August 30, 2026 05:53
@dmitrivMS Dmitriy Vasyura (dmitrivMS) added agent-host Issues for the agent-host implementation (not the protocol) bug Issue identified by VS Code Team member as probable bug labels Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Updates Agent Host CLI output for Windows console compatibility and correct product branding.

Changes:

  • Selects Unicode or ASCII decorations based on Windows console encoding.
  • Propagates terminal capability to detached supervisors.
  • Uses the configured application name in management commands and safely truncates Unicode text.
File Description
cli/​src/​tunnels/​code_server.rs Uses the encoding-safe banner marker.
cli/​src/​commands/​output.rs Centralizes symbol selection and Windows UTF-8 detection.
cli/​src/​commands/​agent_ps.rs Adds ASCII-safe status and warning symbols.
cli/​src/​commands/​agent_logs.rs Adds ASCII-safe decorations and Unicode-safe truncation.
cli/​src/​commands/​agent_host.rs Corrects command branding and propagates encoding capability.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Dmitriy Vasyura and others added 2 commits August 29, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-host Issues for the agent-host implementation (not the protocol) bug Issue identified by VS Code Team member as probable bug

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Agent Host CLI output is garbled and shows the wrong management command on Windows

2 participants