Fix agent host CLI output issues for Windows - #333376
Open
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Open
Fix agent host CLI output issues for Windows#333376Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Conversation
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 30, 2026 05:53
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 30, 2026 05:54
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Updates Agent Host CLI output for Windows console compatibility and correct product branding.
Changes:
- Selects Unicode or ASCII decorations based on Windows console encoding.
- Propagates terminal capability to detached supervisors.
- Uses the configured application name in management commands and safely truncates Unicode text.
| File | Description |
|---|---|
cli/src/tunnels/code_server.rs |
Uses the encoding-safe banner marker. |
cli/src/commands/output.rs |
Centralizes symbol selection and Windows UTF-8 detection. |
cli/src/commands/agent_ps.rs |
Adds ASCII-safe status and warning symbols. |
cli/src/commands/agent_logs.rs |
Adds ASCII-safe decorations and Unicode-safe truncation. |
cli/src/commands/agent_host.rs |
Corrects command branding and propagates encoding capability. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several output issues in the Agent Host CLI on Windows, specifically related to improper character rendering and incorrect branding.
Changes include:
output.rs, ensuring compatibility with Windows consoles.codetocode-insidersinagent_host.rsto reflect the correct branding.agent psandagent logs.GetConsoleOutputCP()to dynamically adjust output formatting.All changes have been validated with passing tests and proper formatting.
Fixes #333375