Repository navigation
style(createHtml): move background color from html to body - #292
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes an issue where the preview background did not fill the entire viewport when a background color was applied to the
body.The issue was caused by the default white background being applied to both the
htmlandbodyelements. Sincehtmlhad an explicit background, the browser could not propagate thebodybackground to the document canvas as it normally would.Key Changes:
htmlelement.bodyto preserve the white preview background.bodybackground across the entire viewport.vh.Screenshots / Evidence
Before
After
Related Issue: #290