Skip to content

🧹 remove unused polling variables - #350

Merged
sebastianMindee merged 2 commits into
mainfrom
scrub-unused-features
Sep 3, 2026
Merged

🧹 remove unused polling variables#350
sebastianMindee merged 2 commits into
mainfrom
scrub-unused-features

Conversation

@sebastianMindee

@sebastianMindee sebastianMindee commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Description

  • ⬆️ bump dependency to cover vulnerability

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It introduces an undocumented breaking/behavior change by removing polling backoff support from both the public API and the client polling behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the v2 Java client by simplifying async job polling configuration/behavior (removing backoff-related options and tests) and bumping the Apache HttpClient 5 dependency version to address a reported vulnerability.

Changes:

  • Remove exponential-backoff support from PollingOptions (fields/validation) and from MindeeClient polling logic.
  • Update unit tests to reflect the reduced polling surface (cancellation-only coverage).
  • Bump org.apache.httpcomponents.client5:httpclient5 from 5.4.4 to 5.6.3.
File summaries
File Description
src/main/java/com/mindee/v2/MindeeClient.java Removes backoff interval growth; polling now uses a fixed interval.
src/main/java/com/mindee/v2/clientoptions/PollingOptions.java Removes backoff-related options from the public polling options API.
src/test/java/com/mindee/v2/MindeeClientTest.java Drops backoff-related test and updates polling display name.
src/test/java/com/mindee/v2/clientoptions/PollingOptionsTest.java Removes backoff assertions and validation tests.
pom.xml Upgrades HttpClient 5 version property.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/main/java/com/mindee/v2/MindeeClient.java
Comment thread src/main/java/com/mindee/v2/clientoptions/PollingOptions.java
@sebastianMindee
sebastianMindee merged commit 8c046f7 into main Sep 3, 2026
15 checks passed
@sebastianMindee
sebastianMindee deleted the scrub-unused-features branch September 3, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants