🧹 remove unused polling variables - #350
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
It introduces an undocumented breaking/behavior change by removing polling backoff support from both the public API and the client polling behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the v2 Java client by simplifying async job polling configuration/behavior (removing backoff-related options and tests) and bumping the Apache HttpClient 5 dependency version to address a reported vulnerability.
Changes:
- Remove exponential-backoff support from
PollingOptions(fields/validation) and fromMindeeClientpolling logic. - Update unit tests to reflect the reduced polling surface (cancellation-only coverage).
- Bump
org.apache.httpcomponents.client5:httpclient5from5.4.4to5.6.3.
File summaries
| File | Description |
|---|---|
| src/main/java/com/mindee/v2/MindeeClient.java | Removes backoff interval growth; polling now uses a fixed interval. |
| src/main/java/com/mindee/v2/clientoptions/PollingOptions.java | Removes backoff-related options from the public polling options API. |
| src/test/java/com/mindee/v2/MindeeClientTest.java | Drops backoff-related test and updates polling display name. |
| src/test/java/com/mindee/v2/clientoptions/PollingOptionsTest.java | Removes backoff assertions and validation tests. |
| pom.xml | Upgrades HttpClient 5 version property. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ianardee
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes