Skip to content

chore: remove CODEOWNERS entries now enforced org-wide (ENG-2013) - #89

Open
hamishfagg wants to merge 1 commit into
mainfrom
hamish/eng-2013-remove-codeowners
Open

chore: remove CODEOWNERS entries now enforced org-wide (ENG-2013)#89
hamishfagg wants to merge 1 commit into
mainfrom
hamish/eng-2013-remove-codeowners

Conversation

@hamishfagg

@hamishfagg hamishfagg commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What

Deletes .github/CODEOWNERS. The org-level ruleset in mindsdb/terraform (newprod/global/github) requires a @mindsdb/devops review on the paths common to all repos, and enforces each repo's CODEOWNERS through require_code_owner_review. So: shared paths leave this file, repo-specific ones stay.

Removed:

.github/ @mindsdb/devops

Why

One org-wide policy in terraform for what every repo shares; CODEOWNERS for what only this repo needs. Neither duplicates the other.

Targets main.

🤖 Generated with Claude Code

@hamishfagg
hamishfagg requested a review from a team September 10, 2026 02:38
@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Paths every repo shares (.github/, Dockerfile, Makefile, docker/, alembic/,
pyproject.toml, ...) now require a @mindsdb/devops review through the org-level
ruleset in mindsdb/terraform, so they leave this file. Anything specific to this
repo stays here; the same ruleset enforces CODEOWNERS via
require_code_owner_review.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@hamishfagg
hamishfagg force-pushed the hamish/eng-2013-remove-codeowners branch from 89ced64 to 3ef75c0 Compare September 10, 2026 05:07
@hamishfagg hamishfagg changed the title chore: remove CODEOWNERS, now enforced by the org ruleset (ENG-2013) chore: remove CODEOWNERS entries now enforced org-wide (ENG-2013) Sep 10, 2026

@lucas-koontz lucas-koontz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: Reviewed the CODEOWNERS deletion and effective rules on main. The live organization baseline already requires DevOps approval for .github changes, so this removes duplicate ownership. Unit tests passed. The CLA check requires a contributor signature; that result is unrelated to this deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants