Repository navigation
Pin h5p-author 0.9.3 - #31
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30.
h5p-author 0.9.3 (missing-elements/h5p-offline-player@ebd0394) changes one paragraph of the skill's step 3: a build page link that carries the source is only ever one a command printed, and where nothing runs, the chat gives no link and puts the whole source in its reply for the user to paste. The build does not change.
What changes
package.jsonand the lockfile:@missing-elements/h5p-author0.9.2 → 0.9.3. The lockfile change is the five lines of that entry, with the integrity npm gives for 0.9.3; its dependencies are 0.9.2's./h5p/skill/SKILL.mdis 0.9.3's. The brief and the 32 type files, under/h5p/skill/and/h5p/build/types/, are as in 0.9.2. The page names h5p-author 0.9.3, and/h5p/bundles/index.jsonsays author 0.9.3, with the same 55 bundles from pack 1.1.0.Tested
pnpm build,pnpm typecheckandpnpm e2e: 38 pass. After the build,_site/h5p/skill/SKILL.md,LICENSE,references/authoring.mdand all 32 type files, under/h5p/skill/and/h5p/build/types/, are byte for byte the files of the published 0.9.3 tarball.Summary by cubic
Pins
@missing-elements/h5p-authorto 0.9.3, closing #30. The new version changes one paragraph of the skill's step 3: when nothing runs in a build, the chat no longer prints a build-page link and instead puts the whole source in its reply. The build output is unchanged, and 0.9.3's dependencies are identical to 0.9.2's.Verified with
pnpm build,pnpm typecheck, andpnpm e2e(38 pass); the generated skill and type files match the published 0.9.3 tarball.Written for commit ec48902. Summary will update on new commits.