Repository navigation
Pin h5p-author 0.9.4 - #34
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
h5p-author 0.9.4 (missing-elements/h5p-offline-player#188) changes three things in the skill (
SKILL.md) and the Fill in the Blanks and Drag the Words type files:/or:, as/and:.licenseVersion.What changes
package.jsonand the lockfile move@missing-elements/h5p-authorfrom 0.9.3 to 0.9.4. The lockfile change is the five lines of that entry, with the integrity npm gives for 0.9.4; its dependencies are the same as 0.9.3's./h5p/skill/SKILL.mdand the H5P.Blanks and H5P.DragText type files, under/h5p/skill/and/h5p/build/types/, are 0.9.4's. The brief and the other 30 type files are as in 0.9.3./h5p/bundles/index.jsonsays author 0.9.4, with the same 55 bundles from pack 1.1.0.h5p-author.mjsnow give the new problems. One is for a backslash in a Blanks gap: "a backslash escapes nothing in a gap". One is for a Drag the Words gap whose feedback holds a colon. The licence one now says the value "holds the version too".Tested
pnpm install --frozen-lockfile,pnpm buildandpnpm typecheckpass.pnpm e2e: 38 pass._site/h5p/are byte for byte the files of the published 0.9.4 tarball:skill/SKILL.md,LICENSE,references/authoring.md, and all 32 type files under both/h5p/skill/and/h5p/build/types/. No file in the built site names 0.9.3.Summary by cubic
Pins
@missing-elements/h5p-authorto 0.9.4, closing #33.0.9.4 updates the skill and type files (specifying where a Creative Commons licence's version goes, and how gaps escape
/and:), and the build page now reports two new problems: a backslash in a Blanks gap, and a colon in a Drag the Words gap's feedback.Written for commit 39d3ef1. Summary will update on new commits.