Preserve immutable STIX fields during workflow updates - #497
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## beta #497 +/- ##
=======================================
Coverage 81.12% 81.12%
=======================================
Files 245 245
Lines 39356 39366 +10
Branches 4820 4822 +2
=======================================
+ Hits 31926 31936 +10
Misses 7342 7342
Partials 88 88 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 4.21.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a relationship updates the workflow state of its source and target through PUTs. Those requests omitted a couple of stored STIX fields, and the backend interpreted their absence as an attempt to alter an immutable revision.
Any new relationship created was causing this issue. This PR addresses that by persisting the
x_mitre_modief_by_refandobject_marking_refsvalues.Related to PR open on the workbench frontend