Repository navigation
deps: update chokidar dependency - #461
Open
nathanmmiller wants to merge 1 commit into
Open
nathanmmiller wants to merge 1 commit into
nathanmmiller wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f600569 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mizdra
reviewed
Oct 26, 2026
| "dependencies": { | ||
| "@css-modules-kit/core": "workspace:^", | ||
| "chokidar": "^4.0.3" | ||
| "chokidar": "5.0.0" |
Owner
There was a problem hiding this comment.
Why isn't it ^5.0.0? With 5.0.0, minor and patch updates would be blocked, which isn't a good approach.
mizdra
reviewed
Oct 26, 2026
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@css-modules-kit/codegen': major | |||
Owner
There was a problem hiding this comment.
Why was "major" selected as the bump type? The update to chokidar 5.0.0 should not introduce any breaking changes to css-modules-kit. Since it also doesn’t introduce any new features, I think "patch" would be the appropriate bump type.
mizdra
added
the
Type: Dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #460