Skip to content

fix(npm): hide native CLI consoles on Windows - #144

Merged
Grivn merged 2 commits into
mnemon-dev:masterfrom
Oscar-Williams:fix/143-windows-hide-npm-cli
Sep 24, 2026
Merged

Grivn merged 2 commits into
mnemon-dev:masterfrom
Oscar-Williams:fix/143-windows-hide-npm-cli

Conversation

@Oscar-Williams

@Oscar-Williams Oscar-Williams commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

What

Pass windowsHide: true to both npm launcher paths that start or synchronously invoke the native Mnemon binary. Add Node regression coverage for the default and explicit override behavior.

Why

Closes #143. GUI-hosted agent harnesses on Windows otherwise create a visible console window on every mnemon invocation, which is especially disruptive for periodic status polling.

Validation

  • npm test --prefix npm/cli (13 passed on Node 24; the mock uses the Node 22-compatible namedExports option)
  • node --check for the changed launcher and test modules
  • git diff --check
  • Current fork CI run 35971834668 is action_required pending maintainer approval.
  • make test was not run locally because this Windows checkout has no Go toolchain; the existing CI workflow runs it on Ubuntu and Windows.

Checklist

  • Deterministic tests pass (make test)
  • Relevant E2E/process/Docker boundaries are unaffected (npm launcher-only change)
  • New/changed behavior is covered by tests
  • Documentation update is not applicable (no user-facing command or configuration change)
  • No release-note impact; the npm launcher remains behaviorally identical except for suppressing Windows console creation

Pass windowsHide to both native launcher paths so GUI-hosted harnesses do not flash a console on each invocation. Add Node test coverage for the default and explicit override behavior.
@Grivn
Grivn merged commit e9ce994 into mnemon-dev:master Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: npm CLI spawns the native binary without windowsHide — a terminal window flashes on every invocation

2 participants