Repository navigation
fix(npm): hide native CLI consoles on Windows - #144
Merged
Grivn merged 2 commits intoSep 24, 2026
Merged
Conversation
Pass windowsHide to both native launcher paths so GUI-hosted harnesses do not flash a console on each invocation. Add Node test coverage for the default and explicit override behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pass
windowsHide: trueto both npm launcher paths that start or synchronously invoke the native Mnemon binary. Add Node regression coverage for the default and explicit override behavior.Why
Closes #143. GUI-hosted agent harnesses on Windows otherwise create a visible console window on every
mnemoninvocation, which is especially disruptive for periodic status polling.Validation
npm test --prefix npm/cli(13 passed on Node 24; the mock uses the Node 22-compatiblenamedExportsoption)node --checkfor the changed launcher and test modulesgit diff --checkmake testwas not run locally because this Windows checkout has no Go toolchain; the existing CI workflow runs it on Ubuntu and Windows.Checklist
make test)