Repository navigation
term: allow compiling for js/wasm #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thaJeztah
wants to merge
1
commit into
moby:main
Choose a base branch
from
thaJeztah:webassembly_stubs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| //go:build !windows | ||
| //go:build !js && !wasip1 && !windows | ||
|
|
||
| package term | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,56 @@ | ||||||||||||||||||||||||||||||
| //go:build js || wasip1 | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| package term | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| import ( | ||||||||||||||||||||||||||||||
| "fmt" | ||||||||||||||||||||||||||||||
| "io" | ||||||||||||||||||||||||||||||
| "os" | ||||||||||||||||||||||||||||||
| "runtime" | ||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| // terminalState holds the platform-specific state / console mode for the terminal. | ||||||||||||||||||||||||||||||
| type terminalState struct{} | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func stdStreams() (stdIn io.ReadCloser, stdOut, stdErr io.Writer) { | ||||||||||||||||||||||||||||||
| return os.Stdin, os.Stdout, os.Stderr | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func getFdInfo(in any) (uintptr, bool) { | ||||||||||||||||||||||||||||||
| if file, ok := in.(*os.File); ok { | ||||||||||||||||||||||||||||||
| return file.Fd(), false | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| return 0, false | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func getWinsize(fd uintptr) (*Winsize, error) { | ||||||||||||||||||||||||||||||
| return nil, fmt.Errorf("terminal: GetWinsize not implemented on %s/%s", runtime.GOOS, runtime.GOARCH) | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func setWinsize(fd uintptr, ws *Winsize) error { | ||||||||||||||||||||||||||||||
| return fmt.Errorf("terminal: SetWinsize not implemented on %s/%s", runtime.GOOS, runtime.GOARCH) | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func isTerminal(fd uintptr) bool { | ||||||||||||||||||||||||||||||
| return false | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func restoreTerminal(fd uintptr, state *State) error { | ||||||||||||||||||||||||||||||
| return fmt.Errorf("terminal: RestoreTerminal not implemented on %s/%s", runtime.GOOS, runtime.GOARCH) | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func saveState(fd uintptr) (*State, error) { | ||||||||||||||||||||||||||||||
| return nil, fmt.Errorf("terminal: SaveState not implemented on %s/%s", runtime.GOOS, runtime.GOARCH) | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func disableEcho(fd uintptr, state *State) error { | ||||||||||||||||||||||||||||||
| return fmt.Errorf("terminal: DisableEcho not implemented on %s/%s", runtime.GOOS, runtime.GOARCH) | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func setRawTerminal(fd uintptr) (*State, error) { | ||||||||||||||||||||||||||||||
| return fmt.Errorf("terminal: SetRawTerminal not implemented on %s/%s", runtime.GOOS, runtime.GOARCH) | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func setRawTerminalOutput(uintptr) (*State, error) { | ||||||||||||||||||||||||||||||
| return fmt.Errorf("terminal: SetRawTerminalOutput not implemented on %s/%s", runtime.GOOS, runtime.GOARCH) | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
Comment on lines
+50
to
+56
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably have a GHA build with |
||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| //go:build !windows | ||
| //go:build !js && !wasip1 && !windows | ||
|
|
||
| package term | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| //go:build js || wasip1 | ||
|
|
||
| package term | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "runtime" | ||
| ) | ||
|
|
||
| func makeRaw(fd uintptr) (*State, error) { | ||
| return nil, fmt.Errorf("terminal: MakeRaw not implemented on %s/%s", runtime.GOOS, runtime.GOARCH) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we bump Go to 1.19 we can change this to: