Repository navigation
Respect explicit stubs when detecting contract-generation cycles - #5008
Open
Kieran-Hulsman wants to merge 2 commits into
Open
Kieran-Hulsman wants to merge 2 commits into
Kieran-Hulsman wants to merge 2 commits into
Conversation
github-actions
Bot
added
Z-EndToEndBenchCI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5007
Kani reports a recursion error when a verified stub’s return type has an
Arbitraryimplementation that calls the stubbed function, even if an explicit replacement breaks that cycle.Make the cycle detector follow the configured replacements rather than the original function bodies. Genuine cycles remain rejected.
Added tests for:
Arbitrary::anyto break a cycle.u8andu64.Confirmed the error occurs on
mainand is resolved by this change. Deliberately incorrect assertions fail verification as expected.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.