Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import io.modelcontextprotocol.server.McpTransportContextExtractor;
import io.modelcontextprotocol.server.transport.DefaultServerTransportSecurityValidator;
import io.modelcontextprotocol.server.transport.HeaderAccessor;
import io.modelcontextprotocol.server.transport.HttpServletRequestUtils;
import io.modelcontextprotocol.server.transport.ServerHttpHeaderValidator;
import io.modelcontextprotocol.server.transport.ServerTransportSecurityException;
import io.modelcontextprotocol.util.Assert;
Expand Down Expand Up @@ -185,6 +186,11 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
response.sendError(e.getStatusCode(), e.getMessage());
return;
}
if (!HttpServletRequestUtils.isJsonContentType(request.getContentType())) {
response.sendError(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE,
"Unsupported Media Type: Content-Type must be application/json");
return;
}
if (request.getContentLengthLong() > this.requestMaxSize) {
response.sendError(HttpServletResponse.SC_REQUEST_ENTITY_TOO_LARGE);
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*
* @author Daniel Garnier-Moiroux
*/
final class HttpServletRequestUtils {
public final class HttpServletRequestUtils {

private static final String APPLICATION_JSON = "application/json";

Expand All @@ -35,7 +35,7 @@ private HttpServletRequestUtils() {
* @param contentType The {@code Content-Type} header value, may be {@code null}
* @return {@code true} if the media type is {@code application/json}
*/
static boolean isJsonContentType(String contentType) {
public static boolean isJsonContentType(String contentType) {
if (contentType == null) {
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.NullAndEmptySource;
import org.junit.jupiter.params.provider.ValueSource;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;

Expand Down Expand Up @@ -198,6 +201,36 @@ void singleToolCallReturnsJson() throws Exception {
.hasValueSatisfying(v -> assertThat(v).contains("application/json"));
}

@ParameterizedTest
@NullAndEmptySource
@ValueSource(strings = { "text/plain", "application/x-www-form-urlencoded", "multipart/form-data",
"application/json-rpc", "application/jsonp", "text/plain; a=application/json" })
void postWithNonJsonContentTypeIsRejected(String contentType) throws Exception {
HttpRequest original = post("tools/call", Map.of("_meta", meta(), "name", "echo")).header("Mcp-Name", "echo")
.build();
HttpRequest.Builder builder = HttpRequest.newBuilder(original,
(name, value) -> !name.equalsIgnoreCase("Content-Type"));
if (contentType != null) {
builder.header("Content-Type", contentType);
}
HttpResponse<String> response = HttpClient.newHttpClient()
.send(builder.build(), HttpResponse.BodyHandlers.ofString());

assertThat(response.statusCode()).isEqualTo(415);
}

@ParameterizedTest
@ValueSource(strings = { "application/json; charset=utf-8", "Application/JSON", "Application/JSON; charset=UTF-8" })
void postWithJsonContentTypeIsAccepted(String contentType) throws Exception {
HttpRequest request = post("tools/call", Map.of("_meta", meta(), "name", "echo")).header("Mcp-Name", "echo")
.setHeader("Content-Type", contentType)
.build();
HttpResponse<String> response = HttpClient.newHttpClient().send(request, HttpResponse.BodyHandlers.ofString());

assertThat(response.statusCode()).isEqualTo(200);
assertThat(response.body()).contains("echo:echo");
}

@Test
void streamingToolCallReturnsSse() throws Exception {
Map<String, Object> meta = meta();
Expand Down
Loading