Simplify get_display_name logic. - #3498
Conversation
Deduplicate title-first precedence shared across all object types. Only Tool-specific annotations.title remains as a special middle branch. Fixes modelcontextprotocol#3480
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3480. If a maintainer assigns you to #3480, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Problem
get_display_nameduplicated title-first precedence acrossTooland non-Tool branches (title > namevstitle > annotations.title > name). OnlyTool.annotations.titleneeds a special middle branch.Solution
Hoist the shared
titlecheck before theToolbranch. Keep theTool.annotations.titlefallback as the only type-specific branch. Fall through toname. No behavioral change.Impact
Less branching, single title precedence path, easier to maintain. No API change.
Evidence
python -m py_compile src/mcp/shared/metadata_utils.py-> okruff check src/mcp/shared/metadata_utils.py-> All checks passedFixes #3480