Skip to content

Close the transport when connect_to_server rejects a session - #3502

Closed
gyanu2507 wants to merge 1 commit into
modelcontextprotocol:mainfrom
gyanu2507:fix/3490-close-rejected-session
Closed

Close the transport when connect_to_server rejects a session#3502
gyanu2507 wants to merge 1 commit into
modelcontextprotocol:mainfrom
gyanu2507:fix/3490-close-rejected-session

Conversation

@gyanu2507

Copy link
Copy Markdown

Fixes #3490

A rejected connect_to_server (duplicate tool name, for example) left the transport's exit stack in _session_exit_stacks and never closed it. The child process or HTTP session kept running.

connect_to_server now pops that stack and acloses it on any exception from connect_with_session.

The existing duplicate-tool test registers a mock stack and asserts aclose.

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Sep 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3490.

If a maintainer assigns you to #3490, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientSessionGroup: a rejected connect_to_server leaves its transport running — the session is established before its components are validated

1 participant