Close the transport when connect_to_server rejects a session - #3502
Close the transport when connect_to_server rejects a session#3502gyanu2507 wants to merge 1 commit into
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3490. If a maintainer assigns you to #3490, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Fixes #3490
A rejected
connect_to_server(duplicate tool name, for example) left the transport's exit stack in_session_exit_stacksand never closed it. The child process or HTTP session kept running.connect_to_servernow pops that stack andacloses it on any exception fromconnect_with_session.The existing duplicate-tool test registers a mock stack and asserts
aclose.