fix(auth): preserve state on authorization error redirects - #2774
Open
Ssavan99 wants to merge 4 commits into
Open
fix(auth): preserve state on authorization error redirects#2774Ssavan99 wants to merge 4 commits into
Ssavan99 wants to merge 4 commits into
Conversation
authorizationHandler read `state` out of the parse result after the parse had already been checked, so any Phase-2 validation failure threw before `state` was assigned and the error redirect went out without it. RFC 6749 4.1.2.1 requires `state` on the error response whenever the request carried one. A client performing the standard CSRF check has to reject a callback that lacks it, so the underlying `invalid_request` never reaches the user. Capture `state` from the raw request parameters before validation runs.
🦋 Changeset detectedLatest commit: fe54b46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2773
authorizationHandlerreadstateout of the parse result after the parse hadalready been checked, so any Phase-2 validation failure threw before
statewasassigned and the error redirect went out without it. RFC 6749 §4.1.2.1 requires
stateon the error response whenever the request carried one, and a clientdoing the standard CSRF check has to reject a callback that lacks it — so the
underlying
invalid_requestnever reaches the user.Capture
statefrom the raw request parameters before validation runs.Tests
Four cases added to
authorize.test.ts:code_challenge→ error redirect keepsstatecode_challenge_method=plain→ error redirect keepsstatestate→ error redirect still omits it (no regression)The first three fail on
mainand pass with the fix. Fullserver-legacysuite:172 passed.
typecheck,eslint, andprettierclean.Disclosure: found and patched with AI assistance (Claude Code). I have reviewed
the diagnosis, the fix, and the tests, and can speak to any of it.