Skip to content

chore: stop publishing the compose Postgres on a host port - #243

Merged
lesnik512 merged 1 commit into
mainfrom
chore/compose-no-host-port
Oct 17, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
chore/compose-no-host-port

Conversation

@lesnik512

Copy link
Copy Markdown
Member

No issue. The compose postgres service no longer publishes 5432:5432 on the host.

Why

Every just test and just bench-check brings up its own compose project, named after the checkout's directory. With a fixed host port, a second checkout or worktree can't start Postgres while another one is running: "Bind for 0.0.0.0:5432 failed: port is already allocated". Nothing needs the host port:

  • just test, just bench-check and just bench-report reach Postgres inside the compose network, at postgres:5432.
  • CI uses GitHub Actions service containers, not compose.

What changes for contributors

  • Host-side pytest: uv run pytest on the host can no longer reach the compose Postgres, so tests/test_integration.py skips there unless POSTGRES_DSN points at a Postgres of your own. AGENTS.md now says to run the DB tests through just test.
  • psql: reach the database with docker compose exec postgres psql -U outbox outbox.

Verification

just test tests/test_integration.py passes (102 tests) while another compose project already holds host port 5432.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Benchmark gate

✅ gate passed

scenario msg/s delete/msg WALrec/msg WALB/msg fpi upd del dead_tup
consumer/w1/b10 1335 1.000 6.72 921 242 5000 5000 10000
consumer/w1/b100 1432 1.000 7.11 1154 243 5000 5000 10000
consumer/w2/b10 1618 1.000 6.72 924 242 5000 5000 10000
consumer/w2/b100 1797 1.000 7.11 1154 243 5000 5000 10000
consumer/w4/b10 1665 1.000 6.74 947 242 5000 5000 10000
consumer/w4/b100 1984 1.000 7.11 1153 243 5000 5000 10000
consumer/w1/b100/tfbs100 5420 0.010 6.11 1130 243 5000 5000 10000
consumer/w1/b100/interval1-10 1440 1.000 7.17 1196 265 5000 5000 10000
producer/w1/b100 3051 0.000 3.04 597 1 0 0 0
producer/w1/b100/ppt1 972 0.000 4.04 635 0 0 0 0

Gated (fails the build): delete_calls + tuple counters (upd/del/ins) + the producer's insert_calls, exact; select_calls and other_calls within +2; wal_records within a 10% band; fetch_calls within 2x. msg/s, WAL bytes and total calls are informational (timing/FPI noise).

@lesnik512
lesnik512 force-pushed the chore/compose-no-host-port branch from 8f2d9af to a787e07 Compare October 17, 2026 18:42
@lesnik512
lesnik512 merged commit 1f6c78d into main Oct 17, 2026
13 checks passed
@lesnik512
lesnik512 deleted the chore/compose-no-host-port branch October 17, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant