Repository navigation
chore: stop publishing the compose Postgres on a host port - #243
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
lesnik512
force-pushed
the
chore/compose-no-host-port
branch
from
October 17, 2026 18:42
8f2d9af to
a787e07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue. The compose
postgresservice no longer publishes5432:5432on the host.Why
Every
just testandjust bench-checkbrings up its own compose project, named after the checkout's directory. With a fixed host port, a second checkout or worktree can't start Postgres while another one is running: "Bind for 0.0.0.0:5432 failed: port is already allocated". Nothing needs the host port:just test,just bench-checkandjust bench-reportreach Postgres inside the compose network, atpostgres:5432.What changes for contributors
uv run pyteston the host can no longer reach the compose Postgres, sotests/test_integration.pyskips there unlessPOSTGRES_DSNpoints at a Postgres of your own. AGENTS.md now says to run the DB tests throughjust test.docker compose exec postgres psql -U outbox outbox.Verification
just test tests/test_integration.pypasses (102 tests) while another compose project already holds host port 5432.