Repository navigation
docs: say Celery tasks resolve from their own app's container - #712
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: fb14c4f | Previous: 1ab56f7 | Ratio |
|---|---|---|---|
benchmarks/test_guard_by_type.py::test_g16_resolve_by_type |
3513686.8997147717 iter/sec (stddev: 1.896343344873201e-8) |
3295060.0031978656 iter/sec (stddev: 1.116031527934801e-8) |
0.94 |
benchmarks/test_guard_by_type.py::test_g17_resolve_by_type_large_registry |
3428620.4088592962 iter/sec (stddev: 1.7031291845114205e-8) |
3283809.4370063078 iter/sec (stddev: 1.4173263972449579e-8) |
0.96 |
benchmarks/test_guard_cold.py::test_g8_cold_first_resolve |
16276.182865006249 iter/sec (stddev: 0.00005070235534309479) |
15653.36547693717 iter/sec (stddev: 0.00005330734148988303) |
0.96 |
benchmarks/test_guard_cold.py::test_g8b_cold_first_resolve_cached |
12708.973398469188 iter/sec (stddev: 0.00012590124321788435) |
12643.599185428624 iter/sec (stddev: 0.00012834152057065646) |
0.99 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[1] |
477.8290789157267 iter/sec (stddev: 0.00009316078082019136) |
482.0103960273108 iter/sec (stddev: 0.000040929640389662753) |
1.01 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[2] |
467.6501444972419 iter/sec (stddev: 0.000059854782785879756) |
466.98481482480724 iter/sec (stddev: 0.00005225999828170518) |
1.00 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[4] |
434.3150443944577 iter/sec (stddev: 0.0001930314267195275) |
441.37643881544295 iter/sec (stddev: 0.00005796338835234036) |
1.02 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[1] |
13534.811026345096 iter/sec (stddev: 0.000007082475816461441) |
13410.262046574411 iter/sec (stddev: 0.000009446368723884603) |
0.99 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[2] |
6752.841173501653 iter/sec (stddev: 0.000020605361438816942) |
6298.166210212872 iter/sec (stddev: 0.000022561827079881507) |
0.93 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[4] |
3359.166348965601 iter/sec (stddev: 0.00014409729934741492) |
3347.277907138026 iter/sec (stddev: 0.00004282769464877946) |
1.00 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[1] |
9782.311770539272 iter/sec (stddev: 0.00003172920554844763) |
10265.29017101908 iter/sec (stddev: 0.000009745046267461395) |
1.05 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[2] |
4364.600543567589 iter/sec (stddev: 0.000030285676851668076) |
4210.137653619429 iter/sec (stddev: 0.00003968521267353983) |
0.96 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[4] |
2059.4028576062847 iter/sec (stddev: 0.00004299035452119346) |
2005.8336998707966 iter/sec (stddev: 0.00004159090640709475) |
0.97 |
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[1] |
40380.35603379602 iter/sec (stddev: 0.0000046871087810956766) |
39978.79791159435 iter/sec (stddev: 0.0000046903461372401175) |
0.99 |
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[2] |
15142.099136521729 iter/sec (stddev: 0.00001243915538608556) |
14280.566481746599 iter/sec (stddev: 0.00001735381504383091) |
0.94 |
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[4] |
6396.30276644309 iter/sec (stddev: 0.000030436606827701005) |
5597.8804558565935 iter/sec (stddev: 0.00004204870125288695) |
0.88 |
benchmarks/test_guard_lifecycle.py::test_g6_build_child_container |
1616857.812276945 iter/sec (stddev: 3.154303986437856e-8) |
1533196.4827740886 iter/sec (stddev: 2.86275312137151e-8) |
0.95 |
benchmarks/test_guard_lifecycle.py::test_g6b_build_child_container_auto_scope |
1709918.6309643649 iter/sec (stddev: 1.760401405517344e-8) |
1636130.1382760175 iter/sec (stddev: 1.7125501977531598e-8) |
0.96 |
benchmarks/test_guard_lifecycle.py::test_g7_request_lifecycle_batch |
3139.4155932548315 iter/sec (stddev: 0.000009682718954733597) |
3166.7632787842144 iter/sec (stddev: 0.000009921342675537852) |
1.01 |
benchmarks/test_guard_lifecycle.py::test_g7c_event_loop_floor_control |
58158.36287444581 iter/sec (stddev: 0.0000020909578062205017) |
58104.68229935985 iter/sec (stddev: 0.0000018973056283841838) |
1.00 |
benchmarks/test_guard_lifecycle.py::test_g7b_request_cycle_sync |
416726.6926740397 iter/sec (stddev: 1.1206471079218507e-7) |
410696.8794998128 iter/sec (stddev: 7.94064319044878e-8) |
0.99 |
benchmarks/test_guard_lifecycle.py::test_g13_teardown_at_scale |
66551.7191307252 iter/sec (stddev: 0.0000014956373231407367) |
65645.22410249272 iter/sec (stddev: 0.0000016245649567101723) |
0.99 |
benchmarks/test_guard_lifecycle.py::test_g13b_teardown_at_scale_async_no_finalizers |
597.2346897380739 iter/sec (stddev: 0.0009956455143352366) |
600.459856684243 iter/sec (stddev: 0.0008700231899385623) |
1.01 |
benchmarks/test_guard_resolve.py::test_g1_transient_resolve |
2144745.553018918 iter/sec (stddev: 2.3444299576412906e-8) |
2143719.683779502 iter/sec (stddev: 4.634951459022167e-8) |
1.00 |
benchmarks/test_guard_resolve.py::test_g2_cached_resolve |
3590023.869362639 iter/sec (stddev: 1.782447537346544e-8) |
3542586.1006063917 iter/sec (stddev: 1.4987994907331303e-8) |
0.99 |
benchmarks/test_guard_resolve.py::test_g3_deep_chain |
808653.7433427294 iter/sec (stddev: 4.402136855469301e-8) |
808435.9155997981 iter/sec (stddev: 5.2695998182561405e-8) |
1.00 |
benchmarks/test_guard_resolve.py::test_g4_wide_resolve |
476799.51946172625 iter/sec (stddev: 3.9276924451767917e-7) |
479779.30535954016 iter/sec (stddev: 3.917463905503218e-7) |
1.01 |
benchmarks/test_guard_resolve.py::test_g5_cross_scope |
1984307.8947367969 iter/sec (stddev: 3.652252572672108e-8) |
1993591.5997960276 iter/sec (stddev: 2.7654986308824802e-8) |
1.00 |
benchmarks/test_guard_resolve.py::test_g9_context_resolve |
1396897.8182155932 iter/sec (stddev: 1.483735574912372e-7) |
1434929.4986810752 iter/sec (stddev: 1.287572378470537e-7) |
1.03 |
benchmarks/test_guard_resolve.py::test_g12_override_active_resolve |
824879.9634679196 iter/sec (stddev: 3.6899927607382305e-8) |
821385.6290981806 iter/sec (stddev: 5.4846145263731116e-8) |
1.00 |
benchmarks/test_guard_resolve.py::test_g18_alias_hop |
3618998.4971774374 iter/sec (stddev: 1.0207209165094815e-8) |
3559042.214766902 iter/sec (stddev: 1.6424497407858823e-8) |
0.98 |
benchmarks/test_guard_validate.py::test_g10_validate_deep_chain |
35837.833659371034 iter/sec (stddev: 0.00001860300263572258) |
34476.84960557863 iter/sec (stddev: 0.000020815675124199726) |
0.96 |
benchmarks/test_guard_validate.py::test_g11_validate_wide |
21512.943348401604 iter/sec (stddev: 0.000023205107052453225) |
20747.482986202627 iter/sec (stddev: 0.000024472860896434163) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modern-di-celery 4.2.2 (modern-python/modern-di-celery#51) looks the container up through the running task's app instead of
current_app. The Celery page still said the lookup goes throughcurrent_app; this updates that sentence, describes the fallback outside a task, and names the version that changed it.