Repository navigation
Mark fully deployed services, show picks as chips, and move Release into a folding side column - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four changes to the page; the report schema stays at 6.
Fully deployed services. A service whose production runs the head of the default branch, with no rows left and no collect error, gets a green left border, a light green background, and a
✓ fully deployedbadge in place of the grey "up to date". A--jiraservice inin_productionthat still has rows above its target is not marked.Picked tag as a chip. Once a tag is picked, the service line shows it as a blue chip. The chip's
×clears the pick without opening the line. The Clear pick button inside the open line stays.Release in a side column. The lists and the release post moved from the bottom of the page into a column on the right that stays in view while the services scroll. Each output has its own tab, with a taller text box. Below 1000px the column goes under the services as before. The page's max width went from 1200px to 1680px.
The column folds while a service is open. A 420px column squeezes the rows table: at 1440px titles already wrap. While a service is open, the column becomes a narrow strip reading
Release · 2 tags · 5 tasks, so the table gets almost all the width (1166px at 1280px). Picking a tag closes the line, so the column comes back right away; clicking the strip closes the line too. One new translation key,tagCount, in both languages.The column and strip are shown by CSS from the
foldedclass on the layout, not byx-show. Withx-show, closing one service and opening another quickly could leave Alpine 3.17.4's hide of the column pending forever, so the strip and the full column showed at once.These won over alternatives tried in a throwaway prototype on mock data: grouping deployed services at the bottom or giving each line per-environment lights; a sticky column without tabs or a bottom tray; a checkbox at the start of the line or a tint with a Clear button on the right; and, for narrower screens, a 1280px breakpoint, a fluid column width, or a fold button.
The page has no tests. I checked it in a browser against a mock report with 12 services: six fully deployed, one failed to collect, one never deployed to production, one with a failed tag pipeline. I checked both themes at 1440, 1280 and 900px, English and Russian, the tabs, the chip's
×, and folding. I did not check it against a report from the CLI tests.just testandjust lint-cipass.