Repository navigation
chore(dependencies): drop unused fiona optional dependency - #2884
Merged
Merged
Conversation
fiona has not been imported anywhere in flopy since the shapefile integer check was removed from test_export.py in modflowpy#1737, and the notebook that used it went away with SpatialReference in modflowpy#1200. geopandas >=1.0 uses pyogrio by default, so require that to avoid resolving an older geopandas that would want fiona. fiona publishes no Python 3.14 wheels, so this also fixes the 3.14 example jobs, which fail building fiona from source without GDAL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2884 +/- ##
===========================================
+ Coverage 55.5% 72.0% +16.5%
===========================================
Files 644 659 +15
Lines 124135 132502 +8367
===========================================
+ Hits 68947 95489 +26542
+ Misses 55188 37013 -18175 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fiona has not been imported anywhere in flopy since the shapefile integer check was removed from
test_export.pyin #1737, and the notebook that used it went away withSpatialReferencein #1200.geopandas >=1.0usespyogrioby default, so require that to avoid resolving an older geopandas that would want fiona.This fixes the Py3.14 example jobs, which fail building fiona from source without GDAL since fiona publishes no Py3.14 wheels