Merge upstream v0.1.8-nightly.20261109.4392

.github/workflows/release-desktop.yml

@@ -478,7 +478,7 @@ jobs:
         shell: bash
         run: |
           sudo apt-get update
-          sudo apt-get install -y libsecret-1-dev pkg-config
+          sudo apt-get install -y libsecret-1-dev pkg-config libgtk-3-0t64 libnss3 libasound2t64 libgbm1
           if ! command -v magick >/dev/null 2>&1 && ! command -v convert >/dev/null 2>&1; then
               sudo apt-get install -y imagemagick
           fi

apps/desktop/src/electron/ElectronShell.test.ts

@@ -54,6 +54,67 @@ describe("ElectronShell", () => {
     }).pipe(Effect.provide(ElectronShell.layer)),
   );
 
+  it.effect("opens local editor file deep links", () =>
+    Effect.gen(function* () {
+      openExternalMock.mockResolvedValue(undefined);
+
+      const urls = [
+        "cursor://file/Users/me/repo/file.md:186",
+        "vscode://file/Users/me/repo/file.md:3:7",
+        "vscode-insiders://file/Users/me/repo/file.md",
+        "vscodium://file/C:/Users/me/repo/file.md:3",
+      ];
+      const electronShell = yield* ElectronShell.ElectronShell;
+      const results = yield* Effect.forEach(urls, (url) => electronShell.openExternal(url));
+
+      assert.deepEqual(results, [true, true, true, true]);
+      assert.deepEqual(
+        openExternalMock.mock.calls,
+        urls.map((url) => [url]),
+      );
+    }).pipe(Effect.provide(ElectronShell.layer)),
+  );
+
+  it.effect("normalizes the scheme case of local editor file deep links", () =>
+    Effect.gen(function* () {
+      openExternalMock.mockResolvedValue(undefined);
+
+      const electronShell = yield* ElectronShell.ElectronShell;
+      const result = yield* electronShell.openExternal("VSCode://file/Users/me/repo/file.md:3");
+
+      assert.equal(result, true);
+      assert.deepEqual(openExternalMock.mock.calls, [["vscode://file/Users/me/repo/file.md:3"]]);
+    }).pipe(Effect.provide(ElectronShell.layer)),
+  );
+
+  it.effect("does not open editor URLs that are not absolute local file links", () =>
+    Effect.gen(function* () {
+      openExternalMock.mockResolvedValue(undefined);
+
+      const electronShell = yield* ElectronShell.ElectronShell;
+      const results = yield* Effect.forEach(
+        [
+          "cursor://user@file/Users/me/repo/file.md",
+          "cursor://:secret@file/Users/me/repo/file.md",
+          "cursor://file:8080/Users/me/repo/file.md",
+          "cursor://anysphere.cursor-deeplink/prompt?text=hi",
+          "vscode://vscode.git/clone?url=https%3A%2F%2Fexample.com%2Frepo.git",
+          "cursor://file",
+          "cursor://file/",
+          "cursor:file/Users/me/repo/file.md",
+          "foo://file/Users/me/repo/file.md",
+          "zed://file/Users/me/repo/file.md",
+          "jetbrains://file/Users/me/repo/file.md",
+          "javascript:alert(1)",
+        ],
+        (url) => electronShell.openExternal(url),
+      );
+
+      assert.deepEqual(results, Array(12).fill(false));
+      assert.equal(openExternalMock.mock.calls.length, 0);
+    }).pipe(Effect.provide(ElectronShell.layer)),
+  );
+
   it.effect("does not open editor URLs that mix up link shapes", () =>
     Effect.gen(function* () {
       openExternalMock.mockResolvedValue(undefined);

apps/desktop/src/electron/ElectronShell.ts

@@ -1,5 +1,6 @@
 import { MAC_PERMISSION_SETTINGS_URLS } from "../permissions/MacPermission.ts";
 import {
+  isLocalEditorFileUrl,
   REMOTE_CAPABLE_EDITOR_IDS,
   remoteSchemeForEditor,
   type SystemSettingsPane,
@@ -11,7 +12,7 @@ import * as Option from "effect/Option";
 
 import * as Electron from "electron";
 
-// Remote editor deep links must reach the OS handler.
+// Remote editor deep links and local editor file links must reach the OS handler.
 const SAFE_WEB_PROTOCOLS = new Set(["http:", "https:"]);
 const REMOTE_EDITOR_PROTOCOLS = new Set(
   REMOTE_CAPABLE_EDITOR_IDS.flatMap((id) => {
@@ -44,7 +45,9 @@ export function parseSafeExternalUrl(rawUrl: unknown): Option.Option<string> {
 
   try {
     const url = new URL(rawUrl);
-    return SAFE_WEB_PROTOCOLS.has(url.protocol) || isRemoteEditorUrl(url)
+    return SAFE_WEB_PROTOCOLS.has(url.protocol) ||
+      isRemoteEditorUrl(url) ||
+      isLocalEditorFileUrl(url)
       ? Option.some(url.href)
       : Option.none();
   } catch {

apps/desktop/src/settings/DesktopClientSettings.test.ts

@@ -54,7 +54,6 @@ const clientSettings: ClientSettings = {
   glassOpacity: 80,
   onboardingCompletedAt: null,
   panelAnimationDurationMs: 0,
-  planModeEnabled: false,
   proactivePanelsEnabled: true,
   showSkillsInSlashMenu: false,
   persistComposerContextStrip: true,
@@ -69,7 +68,6 @@ const clientSettings: ClientSettings = {
   boringSidebarMultilineRows: false,
   threadDetailsUsageEnabled: false,
   threadDetailsItems: {},
-  legacySidebarEnabled: false,
   sidebarWorkingShelfEnabled: false,
   loadBalancingEnabled: false,
   loadBalancingWeights: { "environment-1": 75, "environment-2": 0 },

apps/mobile/modules/t3-native-controls/android/src/main/java/expo/modules/t3nativecontrols/T3NativeControlsModule.kt

@@ -1,7 +1,14 @@
 package expo.modules.t3nativecontrols
 
+import android.content.ContentValues
+import android.content.Context
 import android.content.Intent
+import android.net.Uri
+import android.os.Build
+import android.os.Environment
+import android.provider.MediaStore
 import android.text.format.DateFormat
+import androidx.annotation.RequiresApi
 import androidx.core.content.FileProvider
 import expo.modules.kotlin.Promise
 import expo.modules.kotlin.modules.Module
@@ -44,6 +51,15 @@ class T3NativeControlsModule : Module() {
       }
     }
 
+    AsyncFunction("saveImageToLibrary") { uri: String, mimeType: String, name: String ->
+      val context = appContext.reactContext ?: error("The app is not active.")
+      if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+        saveImageToPictures(context, Uri.parse(uri), mimeType, name)
+      } else {
+        error("Saving images needs Android 10 or later.")
+      }
+    }
+
     OnActivityResult { _, (requestCode) ->
       if (requestCode == 7343) {
         filePreviewPromise?.resolve(null)
@@ -84,3 +100,32 @@ class T3NativeControlsModule : Module() {
     }
   }
 }
+
+// Android 10+ lets apps add their own media without a storage permission.
+@RequiresApi(Build.VERSION_CODES.Q)
+private fun saveImageToPictures(context: Context, source: Uri, mimeType: String, name: String) {
+  val resolver = context.contentResolver
+  val values = ContentValues().apply {
+    put(MediaStore.Images.Media.DISPLAY_NAME, name)
+    put(MediaStore.Images.Media.MIME_TYPE, mimeType)
+    put(MediaStore.Images.Media.RELATIVE_PATH, "${Environment.DIRECTORY_PICTURES}/T3 Code")
+    put(MediaStore.Images.Media.IS_PENDING, 1)
+  }
+  val target = resolver.insert(
+    MediaStore.Images.Media.getContentUri(MediaStore.VOLUME_EXTERNAL_PRIMARY),
+    values
+  ) ?: error("Could not create the image in Pictures.")
+  runCatching {
+    val input = resolver.openInputStream(source) ?: error("The image is no longer available.")
+    input.use { from ->
+      val output = resolver.openOutputStream(target) ?: error("Could not write the image.")
+      output.use { from.copyTo(it) }
+    }
+    resolver.update(
+      target,
+      ContentValues().apply { put(MediaStore.Images.Media.IS_PENDING, 0) },
+      null,
+      null
+    )
+  }.onFailure { resolver.delete(target, null, null) }.getOrThrow()
+}

apps/mobile/modules/t3-native-controls/ios/T3NativeControlsModule.swift

@@ -1,7 +1,9 @@
 import AVFoundation
 import ExpoModulesCore
+import Photos
 import Security
 import UIKit
+import UniformTypeIdentifiers
 
 @ExpoModule("T3NativeControls")
 public final class T3NativeControlsModule: Module {
@@ -123,6 +125,11 @@ public final class T3NativeControlsModule: Module {
     AsyncFunction("shareFileFromSource") { (url: URL, title: String, identifier: String, promise: Promise) in
       try self.shareFile(url: url, title: title, sourceIdentifier: identifier, promise: promise)
     }.runOnQueue(.main)
+
+    // Photos names the asset itself, so iOS ignores the Android display name.
+    AsyncFunction("saveImageToLibrary") { (url: URL, mimeType: String, name: String, promise: Promise) in
+      Self.saveImageToLibrary(url: url, mimeType: mimeType, name: name, promise: promise)
+    }
   }
 
   // UIKit presenters are main-actor isolated rather than run on the JS thread
@@ -297,6 +304,35 @@ public final class T3NativeControlsModule: Module {
     if filePresentation?.identifier == identifier { filePresentation?.dismiss() }
   }
 
+  private static func saveImageToLibrary(url: URL, mimeType: String, name: String, promise: Promise) {
+    PHPhotoLibrary.requestAuthorization(for: .addOnly) { status in
+      guard status == .authorized || status == .limited else {
+        promise.reject(NSError(
+          domain: "T3NativePhotos",
+          code: 1,
+          userInfo: [NSLocalizedDescriptionKey: "Allow T3 Code to add photos in Settings."]
+        ))
+        return
+      }
+      PHPhotoLibrary.shared().performChanges({
+        let options = PHAssetResourceCreationOptions()
+        options.uniformTypeIdentifier = UTType(mimeType: mimeType)?.identifier
+        options.originalFilename = name
+        PHAssetCreationRequest.forAsset().addResource(with: .photo, fileURL: url, options: options)
+      }, completionHandler: { saved, error in
+        if saved {
+          promise.resolve(nil)
+        } else {
+          promise.reject(error ?? NSError(
+            domain: "T3NativePhotos",
+            code: 2,
+            userInfo: [NSLocalizedDescriptionKey: "Photos could not save this image."]
+          ))
+        }
+      })
+    }
+  }
+
   private func shareFile(url: URL, title: String, sourceIdentifier: String, promise: Promise) throws {
     guard let presenter = appContext?.utilities?.currentViewController() else {
       throw NSError(

apps/mobile/modules/t3-web-socket/expo-module.config.json

@@ -0,0 +1,4 @@
+{
+  "platforms": ["apple"],
+  "apple": { "modules": ["T3WebSocketModule"] }
+}

apps/mobile/modules/t3-web-socket/ios/T3WebSocket.podspec

@@ -0,0 +1,13 @@
+Pod::Spec.new do |s|
+  s.name = 'T3WebSocket'
+  s.version = '1.0.0'
+  s.summary = 'WebSocket client with permessage-deflate for T3 Code mobile.'
+  s.description = 'React Native ships SocketRocket on iOS, which never negotiates compression. This module dials the T3 server through URLSessionWebSocketTask, which offers permessage-deflate on its own.'
+  s.author = 'T3 Tools'
+  s.homepage = 'https://t3tools.com'
+  s.platform = :ios, '18.0'
+  s.source = { :path => '.' }
+  s.static_framework = true
+  s.dependency 'ExpoModulesCore'
+  s.source_files = '*.swift'
+end