fix(tests): exclude & reject type 3 transactions on Monad - #58
Merged
Conversation
pdobacz
force-pushed
the
fix/type3-not-valid-for
branch
from
September 7, 2026 14:14
1cbfb0d to
89b33d3
Compare
A skip drops the case on every fork; `not_valid_for` drops it only on the forks without blob transactions, so the non-Monad forks keep the coverage. Co-Authored-By: Claude <claude-opus-5>
The forks advertise no blob schedule and fix the blob header fields at zero, so the type EIP-4844 assigns is unknown to them rather than merely unused. The type is checked ahead of the generic transaction validation, so that a transaction failing both reports the type. Co-Authored-By: Claude <claude-opus-5>
pdobacz
force-pushed
the
fix/type3-not-valid-for
branch
from
September 7, 2026 14:15
89b33d3 to
5887754
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small tweak to properly "unsupport" blob txs in Monad forks.
Selectively mark tx type 3 tests as excluded on Monad forks to fill a small coverage gap.
Surfaced during #53 and cherry-picked there
Greptile Summary
The PR consistently removes type-3 blob transaction support from Monad forks and updates fixture selection and exception mapping accordingly.
Confidence Score: 5/5
The PR appears safe to merge; no actionable correctness, security, or repository-rule issues remain.
The prior inconsistency is fully fixed because constructed blob transactions are now rejected before intrinsic-gas and other generic checks, while encoded type-3 transactions are rejected during decoding. The updated exception mapping and Monad-specific test markers are consistent with those paths.
Important Files Changed
TransactionTypeErroroutput.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Transaction input] --> B{Encoded bytes?} B -->|Yes| C{Type byte is 3?} C -->|Yes| D[Raise TransactionTypeError] C -->|No| E[Decode supported transaction] B -->|No| F{Constructed BlobTransaction?} F -->|Yes| D F -->|No| G[Run generic transaction validation] E --> GReviews (2): Last reviewed commit: "feat(monad): reject blob transactions on..." | Re-trigger Greptile