Skip to content

Steven/ga - #74

Merged
stevenphanny merged 3 commits into
mainfrom
steven/ga
Oct 29, 2026
Merged

stevenphanny merged 3 commits into
mainfrom
steven/ga

Conversation

@stevenphanny

Copy link
Copy Markdown
Contributor

No description provided.

stevenphanny and others added 3 commits October 29, 2026 14:56
Next.js 16.4.0 is affected by three published advisories, all fixed in
16.4.3:

- GHSA-2464-fhr4-w9xw (critical): unauthenticated RCE in the Image
  Optimization API when SVG files are used
- GHSA-673q-mjm6-r5xr (critical): unauthenticated RCE in `use cache`
  functions returning typed arrays
- GHSA-p3m5-59mp-jv5r (high): denial of service in the App Router via
  Server Actions

This is a same-major patch bump, so no codemod or migration guide
applies. The webapp pins next exactly at 16.4.3, and the lockfile only
moves next, @next/env and the @next/swc-* binaries.

16.4.3 was published on 2026-10-23, less than 7 days ago. CLAUDE.md §9
allows that exception for a security fix, which this is.

Also set `experimental.agentUpgrade: "security"`, which 16.4.3 supports,
so coding agents only nudge about Next.js security upgrades.

Verified with pnpm lint, pnpm typecheck, the node test suites (webapp,
db, ingest) and a full `next build`.
Load gtag.js through @next/third-parties' GoogleAnalytics component in
the root layout, so every page reports a page view. The measurement ID
is public (it ships in every page), so it lives in code, not .env.

It loads in dev as well as production; filter localhost out by
hostname in the GA reports.

The report-only CSP now allows gtag.js from www.googletagmanager.com
and hits to *.google-analytics.com and *.analytics.google.com.
posthog-js pulled in DOMPurify 3.4.16, which is affected by
GHSA-cg2g-xh64-v4q7 (SAFE_FOR_TEMPLATES bypass) and failed the
`pnpm audit --audit-level=critical` CI step. posthog-js allows
^3.4.13, so only the lockfile changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stevenphanny
stevenphanny merged commit b510217 into main Oct 29, 2026
2 checks passed
coldfinity pushed a commit to coldfinity/monmap that referenced this pull request Nov 14, 2026
Reported on A2000 in 2022: selecting a major offered "Extended major
2" and "Extended major 3". The repeating slots were working as
designed; the labels were wrong, and had been in every year except
2026.

    A2000     major  extended_major
    2022          1              27
    2025          1              29
    2026         29               1     <- same AoS codes

This is feedback monashcoding#66/monashcoding#74/monashcoding#70 ("Arts majors and extended majors are
swapped; psychology is the only major"). The triage recorded it as
closed on the strength of 2026 alone — the same single-year blind spot
the cross-year pass caught in the plan. Two defects in
classifyAosRelationship, both visible in the real labels:

A container can list both kinds. 2022-2025 A2000 uses "Part A. Arts
listed majors and extended major" for the whole list, which 2026
splits into "Part A. Major studies" plus one separate extended major.
Testing for "extended major" first labelled all 27-29 extended,
inverting the course. When both appear, the plural listing is the
container's subject and the extended one is the aside, so the bulk are
majors — which is what 2026 resolves the same codes to.

Whitespace varies. "APAC  - Psychology extended  major" is verbatim
from the corpus, double spaces and all, and an exact "extended major"
test missed it — so a genuine extended major became the only thing
A2000 called a major. That is the "psychology is the only major" half
of the report, and it was wrong in 2026 too.

Attribution was measured rather than assumed: running both the old and
new classifier over every stored label in all seven years changes 353
rows across exactly 3 distinct labels, all of them these two cases. A
full --force backfill also carries pending drift in the older years
from earlier extractor changes (about 50 rows: specialisation ->
elective, other -> major), which the same measurement separated out and
which aligning those years with the current extractor was going to
apply anyway.

Backfilled all seven years. A2000 is now consistent everywhere: 26-31
majors and 1-2 extended majors, no inversion. The only resolver
snapshot drift is D3002 going 29/1 to 28/2 as psychology moves, with
aosGroups and aosGroupOptions unchanged. A2000 is added to the harness
at both 2022 and 2026 so a single-year fix can never look complete
again.

Verified: typecheck clean, 183 webapp tests, 45 db, 27 ingest (6 new,
using the real corpus labels), resolver snapshot OK at 17 cases,
corpus baseline OK.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant