Repository navigation
Let students waive a prerequisite for units - #77
Merged
Merged
Conversation
Some handbook codes carry spaces or tabs, which no completed unit could ever match. That stopped 16 prerequisites in the 2027 handbook from being met (ADS2002 needs "ADS2001 ") and hid prohibitions on 6 units, so FIT5003 with ITO5003 now conflicts.
A waiver counts as met only for that unit's prerequisites. It earns no credit, and corequisites, prohibitions, course progress and other units ignore it. Search ranking treats the unit as ready to take and stops suggesting the waived code for it. Waivers are saved as part of the plan, so each course map has its own. Changing the course or start year or resetting the map clears them, as does loading a plan whose start year is no longer in the database. The CSV lists waivers for units on the plan.
An unmet prerequisite in a placed unit's details gets a Waive button, placed in the requirement tree so its "all of" and "any of" stay readable. A waived one shows as met, with Undo. Where the slot reads another handbook year, the error says which year to switch to. A Waivers dialog lists the plan's waivers for removal and says when one no longer applies. A card relying on a waiver gets a small marker, and the Validate tooltip and toast say so. Changing the course offers Undo when it clears waivers, the start year and reset prompts warn about them, and the printed plan lists waivers for units on the plan.
coldfinity
pushed a commit
to coldfinity/monmap
that referenced
this pull request
Nov 14, 2026
"when i put ats 3146 and ats 2146 only 2146 showed a prohibition but 3146 didnt". Confirmed in the corpus: ATS2146 names ATS3146 and ATS3146 says nothing back, and 1,557 of 2026's 3,041 prohibition edges are one-directional like that. Validation only ever evaluated a unit's own rule, so the conflict lit up on whichever card happened to be the one doing the naming -- and stayed silent on the other, which is the card a student is often looking at. validatePlan now builds a reverse index once per plan (code -> planned units whose rules name it) and validateUnitInSlot merges both directions into a single error. Merging matters: for a mutual pair like FIT1045/FIT1053 the same conflict is reachable twice, and reporting it per-direction would double it on every card. Also swept the rest of the B7 singles rather than leaving them vague: - monashcoding#49 (ENG4099 required but unaddable) is resolved by data refresh -- the unit is gone from 2026, replaced by ENG4801-4804, and appears in no requirement group, AoS list or tree. - #82 (AEH exchange units missing from S2) is resolved -- all three carry "Second semester (Northern)"/"(extended)" offerings and classifyTeachingPeriod prefix-matches those to S2. - monashcoding#54 is working as designed: year-N slots are validated against handbook year N on purpose, and the detail popover already has an opt-in year switcher. - monashcoding#58 is one ambiguous line and the WAM demonstrably only counts graded units already on the plan; it needs the reporter, not a guess. - monashcoding#57, monashcoding#63 and monashcoding#77 are features, not singles. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Students can waive a prerequisite for one unit from its details, ie. waive MAT1830 for FIT3235. It only counts for that unit's prerequisites in that plan and adds no credit, so other units with the same prerequisite still need it. Waivers save with the plan like credit, and clear when the course or start year changes or the map is reset. A Waivers dialog lists them, and print and CSV show the ones for units on the plan.
Also trim stray whitespace from requisite codes, which stopped 16 prerequisites in the 2027 handbook from being met, ie. ADS2002 needing "ADS2001 ", and hid prohibitions on 6 units.