Conversation
mabaasit
requested review from
nbbeeken
and
a lite review from Copilot
and removed request for
Copilot
September 21, 2026 08:50
mabaasit
added this pull request to stack #894
September 21, 2026 08:51
mabaasit
changed the title
mabaasit
commented
Sep 22, 2026
Collaborator
Author
There was a problem hiding this comment.
Rename to parse.spec.ts
Collaborator
Author
There was a problem hiding this comment.
And some of the test cases were extracted to test/parse-test-cases.ts
mabaasit
commented
Sep 22, 2026
| @@ -0,0 +1,477 @@ | |||
| import assert from 'assert'; | |||
Collaborator
Author
There was a problem hiding this comment.
Extracted toJSString tests from packages/query-parser/src/index.spec.ts.
mabaasit
commented
Sep 22, 2026
| @@ -0,0 +1,176 @@ | |||
| import type { | |||
Collaborator
Author
There was a problem hiding this comment.
Copy of packages/query-parser/src/stringify.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
COMPASS-11126
Open Questions
Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬