Conversation
mabaasit
requested review from
LuciaHarcekova
and removed request for
a team
September 21, 2026 08:51
mabaasit
added this pull request to stack #894
September 21, 2026 08:51
mabaasit
changed the title
addaleax
reviewed
Sep 21, 2026
| // Used by this file. | ||
| 'self', | ||
| 'onmessage', | ||
| 'postMessage', |
Collaborator
There was a problem hiding this comment.
Adding const { self, onmessage, postMessage } = globalThis; above this statement should remove this requirement, and we do want to avoid a situation where the "sandbox" could call postMessage()
Collaborator
Author
There was a problem hiding this comment.
Yes, that's much better and will clean this up
| 'parseInt', | ||
| 'encodeURIComponent', | ||
| 'decodeURIComponent', | ||
| 'Buffer', |
Collaborator
There was a problem hiding this comment.
Buffer is a Node.js concept, do we need that?
| '__defineSetter__', | ||
| '__lookupGetter__', | ||
| '__lookupSetter__', | ||
| 'constructor', |
Collaborator
There was a problem hiding this comment.
Object.prototype.constructor is part of standard JS, why are we excluding that?
mabaasit
changed the title
mabaasit
marked this pull request as draft
September 22, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
COMPASS-11128
Open Questions
Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬