Repository navigation
fix(terraform): fail on S3 errors other than a missing plan - #376
Merged
Merged
Conversation
…f reporting no reviewed plan Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tobias0106
marked this pull request as ready for review
October 8, 2026 12:47
tobias0106
requested review from
chandrashekar-dhar
and removed request for
a team
October 8, 2026 12:47
gh05tdog
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #375. Apply's first plan lookup ran
aws s3 cp ... 2>/dev/null, so any failure, including expired credentials or AccessDenied, fell through to the PR-head lookup and ended asNo reviewed plan, pointing atrecoverinstead of the real cause.Now only a 404 falls through to the PR-head lookup; any other S3 error fails the step with the error text.
Tested the helper under
set -euwith a stubbedaws: success uses the plan, 404 falls back, 403 fails with the S3 error.🤖 Generated with Claude Code