Repository navigation
fix: do not resurrect destroyed or rotated sessions - #95
Merged
Merged
Conversation
Upgrade direct modules to current releases and tidy the graph. go mod tidy rewrites the go line to 1.26.0 because redis v9.23.0 and golang.org/x/sys v0.49.0 declare go 1.26.0.
Retry with a zero MaxAttempts now uses its default of three attempts. SQL Get returns the driver error instead of replacing it with gob EOF. Destroy is not written back by the middleware save. Regenerate keeps only a destroyed marker, which Get will not adopt.
Get must not adopt a stored record that contains the destroyed key, including values a coder decoded as a non-int64 number.
acoshift
force-pushed
the
security-fixes
branch
from
October 26, 2026 07:02
17107c6 to
c87a010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Destroyis no longer written back by the middleware save. The response expires the cookie.Regeneratestores only a destroyed marker, andGetwill not adopt a record that contains that key.RetrywithMaxAttempts <= 0performs the default three attempts instead of returning success without calling the inner store.Getreturns a driver error instead of replacing it with a gobEOF.Test plan
TestDestroyAfterChangeDoesNotRestoreandTestDestroyWithResaveDoesNotRestorereplay the original cookie throughstore.MemoryTestRegenerateDropsOldCookiePrivilegesandTestDestroyedMarkerIsNotAdoptedTestRetrySuccessasserts three inner attempts whenMaxAttemptsis 0TestSQLGetReturnsScanErrorrequirescontext.Canceled, notio.EOF