Conversation
Co-Authored-By: GPT-6 Astra <codex@openai.com>
Co-Authored-By: GPT-6 Astra <codex@openai.com>
6c989d4 to
ced6377
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ced63775ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # over independent observers of the new live broadcast map. | ||
| - name: JS origin broadcast map benchmark | ||
| if: ${{ !cancelled() }} | ||
| run: nix develop --command bun js/net/bench/broadcasts.ts |
There was a problem hiding this comment.
Install workspace dependencies before running the benchmark
On the fresh checkout used by this nightly job, no preceding step runs bun install, so this command cannot resolve the workspace imports used by origin.ts. Running the exact command in a checkout without node_modules fails with Cannot find module '@moq/signals', making every nightly workflow red before collecting benchmark results. Install with the frozen lockfile first or invoke the benchmark through a recipe that does so.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. WalkthroughThe origin API adds scoped and unscoped broadcast-map getters backed by memoized route snapshots. Connection-specific options now select a private reconnect loop by default, while explicit Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The benchmark can run from a clean checkout, and no actionable merge-blocking issue remains after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Verdict: MERGE Positive improvement: yes. Worth the complexity: yes. The mutation-keyed shared snapshot for unscoped readers, scoped filtering that reuses Alternatives (forcing every caller to pass This is an automated review, not the maintainer's decision |
Problem
Apps need a live view of origin routes, dynamic serving through a borrowed
Connection.origin, and private reconnect loops for connection-specific options.Approach
Origin.Table.broadcasts(scope)andTable.dynamic(). Unscoped readers share a mutation-keyed snapshot; scoped readers retain announcement filtering semantics.share: truestill refuses those options.Impact
@moq/netAPI: additiveOrigin.Table.broadcasts(scope)getter andOrigin.Table.dynamic()method.share: trueremains a refusal.Verification
just checkjust test(written by GPT-6 Astra)