Skip to content

docs(quest): rank auth expiry clock after auth embedder - #3995

Merged
kixelated merged 1 commit into
mainfrom
claude/quest-auth-order
Sep 23, 2026
Merged

kixelated merged 1 commit into
mainfrom
claude/quest-auth-order

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Moves Auth expiry clock to just below Auth embedder in the m1 list. #3974 made it require auth embedder, which is in flight as #3943, so it shouldn't rank above its blocker.

Public API / wire: none.

(written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated enabled auto-merge (squash) September 23, 2026 21:09
@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7653da2e-e4d1-49c2-b8fc-49d3ddb6598b

📥 Commits

Reviewing files that changed from the base of the PR and between 2139674 and 945a9d9.

📒 Files selected for processing (1)
  • quest/m1/README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T21:12:19.884399Z 945a9d9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

MERGE

Positive improvement? Yes. Auth expiry clock already lists Auth embedder as required, and #3974 called out that dependency on the still-open #3943. Ranking the blocked quest above its blocker in the m1 list was misleading; this one-line move fixes that.

Worth the complexity? Trivial docs reorder, no public API or wire change. Complexity is essentially zero.

Different approach? No better option. Keeping the old order would leave the ranking wrong until #3943 lands; deleting or rewriting the quest is out of scope for a list-order fix.

Head 945a9d9.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated
kixelated merged commit aee97ca into main Sep 23, 2026
3 checks passed
@kixelated
kixelated deleted the claude/quest-auth-order branch September 23, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant