Skip to content

chore(quest): bump quest so spawn-merge prompts about every PR - #4355

Closed
kixelated wants to merge 1 commit into
mainfrom
chore/bump-quest-spawn-merge
Closed

kixelated wants to merge 1 commit into
mainfrom
chore/bump-quest-spawn-merge

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

quest-spawn-merge started /quest-merge without asking for any PR it judged to have no open questions. It counted automated MERGE verdicts, including ones posted on the maintainer's account, as approval, so #4351 and #4350 merged unapproved.

Change

Bumps the quest flake input from a4c3deb to e14de80, which pulls in:

No code, API or wire change. quest skill quest-spawn-merge prints the new text from the dev shell.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T13:23:44.951704Z 7ab093a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

MERGE

Positive improvement: yes. quest-spawn-merge was starting /quest-merge on PRs it judged to have "no open questions," and automated MERGE comments (including ones posted on the maintainer account) counted as approval. That already merged #4351 and #4350 without a human pick. Pinning quest to e14de80 pulls in #14, which makes the skill prompt on every PR and treats review comments as input, not approval. That closes the hole.

Worth the complexity: yes, and there is almost none on the moq side. The diff is only the quest flake pin (flake.nix + flake.lock). No moq code, API, or wire change. The other quest commits in the range (#9, #10, #12, #13) are small skill hand-offs and labelling fixes that ride along with the same pin; none of them widen moq's surface.

Different approach: none better for this fix. You could try to special-case bot MERGE comments in the old "merge with no open question" path, but that stays brittle as long as agents can post on the maintainer account. Forcing an interactive pick per PR is the right default. Confirm with quest skill quest-spawn-merge in the updated dev shell before relying on it in a live session.

This is an automated review, not the maintainer's decision
(Written by Grok)

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 09a39a8a-e00f-4e19-935f-101df12157ef

📥 Commits

Reviewing files that changed from the base of the PR and between ca47661 and 7ab093a.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • flake.nix

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The quest flake input now pins revision e14de8012f32c8d4e7d36e8a62373c225b2c5e07 instead of `a4c3debebeacc142dc31b170f3255d1ccf6e4c9b.

Priority: ⬆️ High

Merge Risk: ⚪ Minimal · up to 7ab09

This updates the Quest tooling revision, and the lock entry matches it. No concrete merge-blocking impact is established, so the change is mergeable with normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 7ab09

The change affects 1 system.

Changed systems: flake.nix

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — flake.nix (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in flake.nix: The quest input URL now pins revision e14de8012f32c8d4e7d36e8a62373c225b2c5e07 instead of a4c3debebeacc142dc31b170f3255d1ccf6e4c9b.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: bumping the quest dependency to update spawn-merge behavior.
Description check ✅ Passed The description directly explains the merge behavior problem, the quest input update, and the expected changes included in the new revision.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Closing: superseded by #4371, which bumped quest to 46d7fe8 (ahead of this PR's e14de80) on main.

(Written by Opus 5.5)

@kixelated kixelated closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant