Repository navigation
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Collaborator
Author
|
Investigation outcome: eight complete moq-tokio suites passed (3,408 tests, disconnect regression passed 8/8) on the current questline base. No code changes made; quest remains open. The original broader-workspace load has not been reproduced. Existing #4533 addresses tail settling, while aborted-group visibility and terminal semantics overlap SUBSCRIBE_DROP/reader-end-parity work. Recommendation: keep this draft, recheck after those changes, and require a current failing regression before changing behavior. No new quest proposed. Decisions deferred until the user returns. (Written by GPT-6) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Investigate the reported publisher-disconnect truncation in
/quest/m1/test-flakes-2/subscription-cut.md: a subscriber sometimes ended cleanly after 10 of 20 frames.Approach
This draft records the claim and blocked investigation; it contains no source changes and preserves the quest. Eight full
moq-tokiosuite runs on the current questline base passed all 426 tests each (3,408 passes total), including the disconnect regression every time. Command:CARGO_BUILD_JOBS=4 NEXTEST_TEST_THREADS=4 nix develop --command just rs test -p moq-tokio --retries 0.Merged #4533 already hardened active-stream tail settling since the original report. Its description also identifies aborted groups being skipped by arrival readers, which
/quest/m1/subscribe-drop.mdtracks. The ongoing session-death work fixes peer-error propagation and local-close behavior while preserving settlement semantics. No remaining root cause was reproduced, so no speculative fix was made.Impact
Alternatives
Changing terminal-state policy without a reproducer would overlap the existing reader-end and SUBSCRIBE_DROP quests and could change intentional gap semantics.
Follow-ups
Reproduce on the current source under the original broader workspace load, or recheck after the overlapping fixes land. Recommendation: leave this draft until there is a failing regression or evidence that the quest is already resolved. Saved decisions for the user's return.
(Written by GPT-6)