[kixelated]

Problem

The AAC parse truncated SBR quest is superseded by #4977 (HE-AAC catalog output). That PR already makes Config::parse refuse an explicit SBR/PS config truncated before its extension rate and core, and makes Config::encode write the full explicit form for object types 5 and 29 instead of refusing them.

Approach

Delete quest/m1/aac-parse-truncated-sbr.md and its entry in quest/m1/README.md. This PR now contains only quest deletions.

The original implementation (encode refusing types 5/29, parse refusing truncated configs) remains in history at 4ce5a4d.

Impact

• None. Quest files only.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 88327a18-ae58-41dd-8850-27802ee5aed6

📥 Commits

Reviewing files that changed from the base of the PR and between 7b8d830 and f37f2ff.

📒 Files selected for processing (2)

• quest/m1/README.md
• quest/m1/aac-parse-truncated-sbr.md

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kixelated]

Grok review of f37f2ff1 (first review; the PR was force-pushed from the code fix at 4ce5a4db down to a quest-only deletion)

Deletes quest/m1/aac-parse-truncated-sbr.md and its README line, since #4977 covers it. I checked that claim against the #4977 diff (head 6a164ac6) and it holds:

• Config::parse now always calls read_core for object types 5 and 29, not only when channelConfiguration is 0, so a config cut off before its extension rate fails with IncompleteConfig. fix(moq-mux): HE-AAC catalog entries name the output, not the LC core #4977 pins this with the [0x2A, 0x10] case in explicit_sbr_and_ps_parse_as_their_output.
• Config::encode writes the full explicit form (extension rate plus an LC core) for 5 and 29, so nothing produces the two-byte form anymore. It also round-trips the fdkaacenc HE-AAC and HE-AACv2 configs.
• The quest's moq-audio test note is handled too: rejects_description_disagreeing_with_the_codec_string moves to a full four-byte HE-AAC config.

Nothing else on main links to aac-parse-truncated-sbr.md besides the README line removed here. The README edit sits a few lines away from #4977's own README deletion (he-aac-catalog-output.md), so the two shouldn't conflict.

Non-blocking

1. fix(moq-mux): HE-AAC catalog entries name the output, not the LC core #4977 is still open. If this merges first and fix(moq-mux): HE-AAC catalog entries name the output, not the LC core #4977 stalls or gets reworked, the truncated-config gap goes untracked. I'd merge it after fix(moq-mux): HE-AAC catalog entries name the output, not the LC core #4977, or fold this deletion into fix(moq-mux): HE-AAC catalog entries name the output, not the LC core #4977 so the quest and its fix land together.
2. CI (Check, Test, Quest) is still queued.

Verdict: MERGE once #4977 lands and CI is green.

This is an automated review, not the maintainer's decision
(Written by Grok)