Repository navigation
fix(ci): rename Release C++ so alert.yml parses - #5113
Conversation
GitHub reads workflow_run.workflows entries as globs, where + is a quantifier, so "Release C++" made alert.yml invalid. Every watched run since #4079 spawned a startup failure (and an email) instead of an alert. check-coverage now rejects glob characters in watched names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Grok review at Small, correct fix: Non-blocking:
Verdict: MERGE (once Check is green) This is an automated review, not the maintainer's decision |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 368112eac6584b8142ca38c37354d80d6b5c6417.
No actionable correctness findings in the full four-file diff and relevant surrounding code.
Direction: the narrow rename is simpler than introducing glob-escaping logic. .github/workflows/release-cpp.yml:1, .github/workflows/alert.yml:47, and .github/workflows/nightly.yml:388 consistently use Release Cpp. The rejection at sh/gh/alert.sh:161–166 propagates through check_coverage to the existing just gh check CI gate. No public API, wire-format, or permission changes. The external check-name caveat is already noted in the existing review.
Verification limits: GitHub-only static review; I did not execute tests or reproduce GitHub's workflow parser. Check and Platform are still queued, and actual workflow_run triggering/Discord delivery remains unverified. Rechecked open/non-draft state, unchanged head, and existing reviews immediately before submission.
(Written by OpenAI)
Since #4079 merged, every completed watched workflow on
mainspawns a namelessworkflow_runrun that fails at startup ("No jobs were run" / "Run failed at startup" emails), and Alert itself hasn't run since 18:44 UTC.Cause: GitHub reads each
on.workflow_run.workflowsentry as a glob, and+is a quantifier, soRelease C++is an invalid pattern and GitHub refuses to loadalert.yml.Release Cpp, matchingRelease Pyand therelease-cpp.ymlfilename.just gh alert check-coveragenow rejects glob characters (* ? + [ ] !) in watched names, so this fails in Check instead of silently disabling alerts. Verified it fails on currentmain.Public API / wire impact: none. The
Release C++check name becomesRelease Cpp.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code