Skip to content

fix(ci): rename Release C++ so alert.yml parses - #5113

Merged
kixelated merged 1 commit into
mainfrom
fix/alert-glob-name
Oct 9, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/alert-glob-name

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Since #4079 merged, every completed watched workflow on main spawns a nameless workflow_run run that fails at startup ("No jobs were run" / "Run failed at startup" emails), and Alert itself hasn't run since 18:44 UTC.

Cause: GitHub reads each on.workflow_run.workflows entry as a glob, and + is a quantifier, so Release C++ is an invalid pattern and GitHub refuses to load alert.yml.

  • Rename the workflow (and its nightly job) to Release Cpp, matching Release Py and the release-cpp.yml filename.
  • just gh alert check-coverage now rejects glob characters (* ? + [ ] !) in watched names, so this fails in Check instead of silently disabling alerts. Verified it fails on current main.

Public API / wire impact: none. The Release C++ check name becomes Release Cpp.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

GitHub reads workflow_run.workflows entries as globs, where + is a
quantifier, so "Release C++" made alert.yml invalid. Every watched run
since #4079 spawned a startup failure (and an email) instead of an alert.
check-coverage now rejects glob characters in watched names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T19:32:30.387995Z 368112e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d5aef8b8-f76d-46cf-8e7c-fa0fc8b4ff5e

📥 Commits

Reviewing files that changed from the base of the PR and between 5566e41 and 368112e.


📒 Files selected for processing (4)
  • .github/workflows/alert.yml
  • .github/workflows/nightly.yml
  • .github/workflows/release-cpp.yml
  • sh/gh/alert.sh


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Grok review at 368112ea

Small, correct fix: + in Release C++ breaks GitHub's glob parsing of on.workflow_run.workflows, and renaming the workflow, the nightly job, and the alert entry together keeps all three in sync. Code search shows no other references to the old name.

Non-blocking:

  • sh/gh/alert.sh: the glob guard in check-coverage is a good tripwire. Note that ! is only special as a leading negation in GitHub filters, so the check is stricter than it needs to be. That's fine, just flagging it in case a future name needs it.
  • If any branch protection rule or ruleset requires the Release C++ check by name, it needs updating manually. That's unlikely for a release workflow, but worth a glance.
  • CI is still queued.

Verdict: MERGE (once Check is green)

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 368112eac6584b8142ca38c37354d80d6b5c6417.

No actionable correctness findings in the full four-file diff and relevant surrounding code.

Direction: the narrow rename is simpler than introducing glob-escaping logic. .github/workflows/release-cpp.yml:1, .github/workflows/alert.yml:47, and .github/workflows/nightly.yml:388 consistently use Release Cpp. The rejection at sh/gh/alert.sh:161–166 propagates through check_coverage to the existing just gh check CI gate. No public API, wire-format, or permission changes. The external check-name caveat is already noted in the existing review.

Verification limits: GitHub-only static review; I did not execute tests or reproduce GitHub's workflow parser. Check and Platform are still queued, and actual workflow_run triggering/Discord delivery remains unverified. Rechecked open/non-draft state, unchanged head, and existing reviews immediately before submission.

(Written by OpenAI)

@kixelated
kixelated merged commit 485269a into main Oct 9, 2026
6 checks passed
@kixelated
kixelated deleted the fix/alert-glob-name branch October 9, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant