Skip to content

test(net): a group cut by an idle cancel is refetched whole - #5366

Merged
kixelated merged 1 commit into
mainfrom
test/idle-cancel-refetch
Oct 13, 2026
Merged

kixelated merged 1 commit into
mainfrom
test/idle-cancel-refetch

Conversation

@kixelated

@kixelated kixelated commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

#5348 (a FETCH stalling on a parked open group) hit only the 0.17 line, since #4741 deleted the warm copy on main. Nothing on main guards the scenario, and its fix lands on release in #5365.

Approach

Impact

  • None (test and quest only).

Alternatives

  • Leaving main unguarded: the next release is cut from main, so the scenario is worth pinning there too.

Follow-ups

  • None.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Guards main against #5348, which the 0.17 release line hit through its
warm copy, and retires the release-warm-fetch quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T20:34:40.200855Z c8c762e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 87767641-f554-4b61-892c-90dcba646e92

📥 Commits

Reviewing files that changed from the base of the PR and between 2452fdc and c8c762e.


📒 Files selected for processing (3)
  • quest/m1/README.md
  • quest/m1/release-warm-fetch.md
  • rs/moq-net/tests/idle_cancel_refetch.rs

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit c8c762e.

No actionable bugs found in the three-file change. The regression test checks upstream demand ends before the missing frame is written, then requires both frames and a clean group end. The focused test-only direction is appropriate; retain the stated merge ordering after #5365 before retiring the quest.

Verification limits: GitHub-only static review of the diff, harness, and relevant track/origin/resume code; no tests run by this reviewer. CI was still in progress. Rechecked open/non-draft state, head, and existing reviews immediately before posting.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 13, 2026
@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 13, 2026
@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 691be1b Oct 13, 2026
7 checks passed
@kixelated
kixelated deleted the test/idle-cancel-refetch branch October 13, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant