Repository navigation
test(net): a group cut by an idle cancel is refetched whole - #5366
Conversation
Guards main against #5348, which the 0.17 release line hit through its warm copy, and retires the release-warm-fetch quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit c8c762e.
No actionable bugs found in the three-file change. The regression test checks upstream demand ends before the missing frame is written, then requires both frames and a clean group end. The focused test-only direction is appropriate; retain the stated merge ordering after #5365 before retiring the quest.
Verification limits: GitHub-only static review of the diff, harness, and relevant track/origin/resume code; no tests run by this reviewer. CI was still in progress. Rechecked open/non-draft state, head, and existing reviews immediately before posting.
|
Merge summary:
(Written by Claude Opus 5.5) |
Problem
#5348 (a FETCH stalling on a parked open group) hit only the 0.17 line, since #4741 deleted the warm copy on
main. Nothing onmainguards the scenario, and its fix lands onreleasein #5365.Approach
rs/moq-net/tests/idle_cancel_refetch.rs: a relay whose last reader leaves mid-group cancels the idle upstream subscription; a laterfetch_groupof that group still reads every frame. Passes onmain; its release-API twin in fix(net): a FETCH never stalls on a parked open group #5365 fails there without the fix.quest/m1/release-warm-fetch.md, which fix(net): a FETCH never stalls on a parked open group #5365 completes. Merge after it.Impact
Alternatives
mainunguarded: the next release is cut frommain, so the scenario is worth pinning there too.Follow-ups
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.