Skip to content

docs(quest): reconcile stale plans and dependencies - #5396

Merged
kixelated merged 3 commits into
mainfrom
codex/quest-audit-consistency
Oct 13, 2026
Merged

kixelated merged 3 commits into
mainfrom
codex/quest-audit-consistency

Conversation

@kixelated

@kixelated kixelated commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The quest audit found completed work still queued, missing prerequisites, and conflicting ownership or API plans across the outstanding tree.

Approach

  • Remove the completed flat-quest migration and the obsolete auth blocker on dropped-sources.
  • Narrow replay catalog to its remaining work and bench buckets to its release backport.
  • Add a stable CI-cache release condition and prerequisite links for TS video-leak accounting and RTC/SRT feeds. (The subscription-order prerequisite was dropped on merge: feat(net): let a subscriber choose group order #5385 landed it and main deleted that quest.)
  • Record the narrow C claim-correctness exception, keep TS-specific reporting in m2, correct lite grant ownership/specification, defer probing mechanism selection to measurements, and align the P2P address lists.

Impact

  • Public API: none in this PR. The plans explicitly reconcile the existing C claim migration, net grant types, and future P2P roster shape.
  • Wire: none in this PR. Planned bitrate-grant changes remain confined to wip lite; IETF AUTH stays unchanged.

Alternatives and decisions

The maintainer confirmed the scope, then answered "all recommendations" to the following frontier. Selected options are marked ✅.

  1. Make the quest tree match current code and settled decisions, resolving the audit findings without broader reprioritization?
    • ✅ Confirm this scope, resolve remaining choices, and prepare the quest-update PR.
    • Limit this pass to completed work, stale text, and missing dependencies; defer API and ownership choices.
  2. Apply the stale-plan corrections and missing dependencies, add the CI cache-release condition, and delete the completed flat-quest migration?
    • ✅ Apply all.
    • Select a smaller subset.
  3. Claim API versus handwritten C freeze?
    • ✅ Allow a narrow correctness exception: migrate C's existing claim API alongside Rust and JS.
    • Block claim epochs until generated C replaces the handwritten API.
  4. TS stats ownership?
    • ✅ Keep TS-specific integration in m2; m1 owns generic media reporting.
    • Move TS integration into m1 Rust reporters and retire the separate m2 quest.
  5. Bitrate grants on IETF sessions?
    • ✅ Keep this quest lite-only: correct its net types and lite specification references; leave IETF unchanged.
    • Expand it to carry caps through the negotiated IETF AUTH extension too.
  6. P2P WebTransport addresses?
    • ✅ Use an ordered address list: signaling and CLI share the representation and dialing order.
    • Advertise one selected address and narrow the CLI plan.

Validation

  • nix develop --command just check passed.
  • quest check: 431 documents valid after merging current main.
  • git diff --check passed; all references to the retired quest removed.
  • Verified the updated Quest pin and absence of remote umbrella branches before retiring the migration quest.

Follow-ups

The new quest/m0/ci-cache-release.md tracks the external prerequisite already blocking #5218. Implementation remains in the existing quests; this PR changes plans only.

(Written by GPT-6)


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 13, 2026 04:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T15:56:10.896864Z 3d61436 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3d88374-78fa-4e0c-b8bf-72ef08aba112
📥 Commits

Reviewing files that changed from the base of the PR and between c52b5f9 and 3d61436.

📒 Files selected for processing (19)
  • quest/m0/README.md
  • quest/m0/ci-cache-release.md
  • quest/m0/self-hosted-ci.md
  • quest/m1/README.md
  • quest/m1/archive/replay-catalog.md
  • quest/m1/bench-buckets.md
  • quest/m1/c/README.md
  • quest/m1/claim-answer-epochs.md
  • quest/m1/dropped-sources.md
  • quest/m1/ffi-shape/README.md
  • quest/m1/quest-flat-lines.md
  • quest/m1/stats/rust.md
  • quest/m1/tstd/mux-overhead.md
  • quest/m1/viewer-upswitch.md
  • quest/m2/rate-grant.md
  • quest/m2/ts-health-stats.md
  • quest/m2/uring-demux.md
  • quest/m3/p2p/cli.md
  • quest/m3/p2p/signal.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

All audit decisions are recorded in the quest plans and PR description. The completed migration is retired, stale scope is narrowed, and prerequisites and ownership are aligned. The merge from current main only refreshed a reference in the retired quest; its deletion remains correct.

The scoped Nix check and quest validation pass after that merge. Codex completed its review with no findings and a thumbs-up. Enabling auto-merge for a3d8271aa1646d7ce6ca469f6c11af0c8104aa43, subject to required CI and the normal merge queue.

(Written by GPT-6)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit a3d8271 across all 20 changed planning files. No actionable findings.

The direction is consistent: reuse landed history recovery and histogram work, make prerequisites explicit, preserve the narrow C correctness exception and lite-only grant scope, and let measurements choose the probing mechanism.

Checked related plans, referenced merged PRs, and relevant HLS, benchmark, and Rust/JS grant code. Static GitHub review only; no tests or quest validation run. External cache-release availability was not independently verified.

@kixelated
kixelated enabled auto-merge October 13, 2026 04:27
@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 13, 2026
…sistency

# Conflicts:
#	quest/m1/subscribe-ranges/model.md
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged current main and resolved the single conflict in quest/m1/subscribe-ranges/model.md by taking main's version. #5385 landed subscription order and main deleted quest/m1/subscribe-ranges/order.md, so this PR's new Required link to it no longer applies. Every other audit decision ("all recommendations") carries over unchanged. I updated the PR description to match.

Checked against main's changes since the last merge: the auth relay-refresh deletion, the p2p peer-grant edit, and the in-band grant renewal (#5282) don't contradict the rate-grant, dropped-sources, or p2p signaling edits here. release still lacks #5268's buckets, so the bench-buckets backport quest stays open. quest check reports 431 documents OK, CI is green, and Codex reviewed 3d61436 with no findings. Queueing.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 98fa3b9 Oct 13, 2026
3 checks passed
@kixelated
kixelated deleted the codex/quest-audit-consistency branch October 13, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant