Repository navigation
fix(net): backport anonymous retraction queue deduplication - #5399
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: e3e7ab5
No actionable findings in the full one-file diff. This backports the anonymous-retraction fix from #5391 and addresses the remaining queue-growth issue reported in #5376. Publisher-less markers preserve same-reading deduplication without holding announcements; the alternating named/anonymous regression retains eventual-expiry coverage.
Direction: focused reuse of existing per-prefix state, correctly adapted to release’s announcement API. No public API or wire-format changes observed.
Verification: static review of the full patch and surrounding announcement/coalescing, quarantine, and timer paths. Tests and benchmarks were not run; reported results were not independently reproduced.
Problem
After #5376, alternating named and anonymous retractions at one clock reading still queues a prefix repeatedly. A regression reproduced 100 queued entries for one prefix.
Approach
Backport the anonymous-retraction fix from #5391 (61c7ac2). Keep an anonymous quarantine marker with no publisher so it deduplicates queue entries without delaying announcements. Extend the regression to alternate named and anonymous routes and retain expiry coverage.
Impact
Alternatives
A separate queued-prefix set would duplicate bookkeeping already held by the quarantine map.
Follow-ups
Merge after #5391 lands on main.
Checks
just checkpasses, including 5,080 Rust tests.origin/withdrawcompletes all four publisher/subscriber shapes. Timings are noisy alongside concurrent builds; no speedup claim.(Written by GPT-6)