Repository navigation
quest(m0): complete ts-duration-fidelity, fixed by #5292 - #5435
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The short captures were a publisher ingest running ~20% slower than real time on CI (64-byte blocking stdin reads), which the fixed-delay export (#4645) drops as late. #5292 fixed the reads; duration-fidelity has passed on every Interop run since. Correct the duration-fidelity docstring for the lead the catalog hold (#5287) now costs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Outcome: the quest's goal was met on Open decision for the maintainer: should a TS exporter that is waiting before the publisher appears recover the roughly 2 s of groups published during #5287's catalog hold?
(Written by Claude Opus 5.5) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge summary:
Decision: the maintainer accepted the roughly 2 s first-groups gap from #5287's catalog hold as that hold's cost. No follow-up quest. Review: Codex gave a thumbs-up on head (Written by Claude Opus 5.5) |
Summary
Completes and deletes
quest/m0/ts-duration-fidelity.md. The cause is already fixed onmainby #5292, so this PR only records the evidence, removes the quest's references, and corrects an outdated comment.Root cause
c0c0bb33), the publisher took about 24 s to deliver the 20.06 s clip. The subscriber's release clock measured the source at -222,204 ppm.11b28de0(2026-10-05) and the failures began once feat(moq-mux)!: fixed-delay jitter buffer and per-PID T-STD admission for TS export #4645 landed.Evidence the fix holds
duration-fidelitychecks across the six TS arms, with 0 failures.duration-fidelity. Their remaining red comes from other quests, such asunroutable.stdin_reads_whole_available_packets, which fails without the fix and runs injust check. It also added a nightly import-throughput benchmark.Remaining lead (accepted)
Since #5287 (2026-10-12), the ratio sits at about 0.926 instead of 1.021. A local capture starts at video PTS 3.48 against the source's 1.4, so exactly the first two GOPs are missing. Import holds the catalog for its two-second mux-rate window, and the exporter then joins at the live edge, so groups published during the hold are never read. This is within the band and was a stated cost of #5287. It does mean a subscriber waiting before the publisher no longer gets the whole stream. This PR updates the
duration-fidelitydocstring, which still claimed at most a GOP of lead. The maintainer accepted this gap as the cost of the catalog hold, so no follow-up is planned.Conflicts
#5306 adds evidence to the deleted quest file. On rebase, that hunk should simply be dropped.
Also restores the trailing newline this PR dropped from
quest/m1/ts-same-instance-resume.md.Impact
test/ts/compliance.py, plus quest files.Tests
just checkpasses.quest checkpasses.just test tspasses locally twice onmain: captured 18.58 s of 20.06 s.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Need help on this PR? Tag
@codesmith-botwith what you need.