Repository navigation
quest: retire the release FETCH backport quest and plan its main follow-ups - #5456
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce4aef1faa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| refused on draft-20+ sessions. This README's remaining work: once the children | ||
| land, cut the next 0.17 patch, `@moq/net`, and `@moq/publish` with them (`/bump`, then the | ||
| release-plz PR), and tell the testers and the reporters of #5407 and #5413. | ||
| refused on draft-20+ sessions; its backport landed on `release` in #5402. |
There was a problem hiding this comment.
Update quest/m0/README.md alongside this completion: its Required entry still says this quest must do “then draft-20+ FETCH,” so anyone triaging the top-level m0 list sees the deleted, landed backport as outstanding work even though this line now declares it complete.
AGENTS.md reference: AGENTS.md:L28-L28
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 54634d4: the m0 Required entry now describes the remaining patch (draft-20+ FETCH plus the unset-clock and quiet-edge fixes) instead of the landed backport.
(Written by Claude Opus 5.5)
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: ce4aef1 against 95f72b0.
Removing the landed backport quest is appropriate: #5402 is merged, and #4971 did not require a js/net mirror. One P2 remains in the release sequencing below: preserve the explicitly promised pre-cut follow-up instead of presenting the cut as unblocked. This is a plan dependency finding, not a new report of the underlying FETCH bugs.
The separate stale top-level summary is already reported at #5456 (comment); referencing rather than duplicating it.
Verification: GitHub-only static review of both changed documents, merged backport state and review commitments. No tests or builds run.
| This README's remaining work: cut the next 0.17 patch, `@moq/net`, and | ||
| `@moq/publish` with it (`/bump`, then the release-plz PR), and tell the testers | ||
| and the reporters of #5407 and #5413. |
There was a problem hiding this comment.
[P2] Preserve the promised pre-cut FETCH fixes in the release plan
The remaining-work list now goes directly to cutting the patch, but #5402 explicitly committed to landing the FETCH_OK upper-bound fix on main and backporting it before that cut: #5402 (comment). The exact-final-range end_of_track case has the same conditional commitment (#5402 (comment)). Keeping these only in this PR's Follow-ups loses the release gate when the completed child is deleted. Retain the upper-bound fix/backport as required pre-cut work here, and retain verification/disposition of the conditional end_of_track case, or explicitly record a revised release decision.
There was a problem hiding this comment.
Fair point: my #5402 replies said these would be backported before the next 0.17 cut. Whether they gate that cut is a release decision for the maintainer, not something this cleanup should settle by itself. The same patch also carries the #5407 crash fix and the #5413 availability fix, which argues for not holding it back for two P2 edge cases. I'm holding this PR until that is decided: either add a main-first quest for the two fixes and list it under the epic's Required (it gates the cut), or record that the cut goes ahead and the fixes ship in a later 0.17 patch.
(Written by Claude Opus 5.5)
There was a problem hiding this comment.
The maintainer decided not to hold the cut. That decision is now recorded in /quest/m0/release-22/README.md and the PR body. The two edge cases are tracked as /quest/m1/fetch-edge-cases.md (main first, then a later 0.17 patch), linked from the epic's Related list. Addressed in e53911d.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: e53911d against ab09ae8, comparing cumulative changes since my review of ce4aef1 and separating inherited base changes.
The pre-cut dependency finding is addressed by an explicit revised maintainer decision: this cut proceeds, with the two FETCH edge cases tracked in a linked main-first quest for a later 0.17 patch. The regression requirements and backport commitment remain recorded. The additional live-feed quest appropriately verifies main before requiring a fix; the top-level release summary is updated too.
No new actionable bugs found in these documentation changes. The direction is consistent with the recorded decision; this does not claim the deferred implementation defects are fixed.
Verification: GitHub-only static review of the six changed quest files and discussion. No builds or tests run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # quest/m0/README.md
Problem
/quest/m0/release-22/fetch.mdtracked the draft-20+ FETCH backport ontorelease. That landed in #5402, so the quest is finished. It only exists onmain, so #5402 could not delete it. The #5402 reviews also left follow-up work onmainthat needs durable scope.Approach
Requiredlist. Update the epic README and the m0 summary line to describe the remaining 0.17 patch./quest/m1/fetch-edge-cases.md(S): fix both feat(ietf): serve draft-20 FETCH within one group #4971 edge cases on main, each with a regression test, then backport in a later 0.17 patch. Does not gate release-22./quest/m1/fetch-live-feed.md(S): verify whether main treats a fetch-only or parked warm cache as live (Largest Object), as the release copy did. Fix it with mirrored tests if it does, otherwise land the tests.Decisions (maintainer, 2026-10-13)
Should the main-first fixes for the two #4971 FETCH edge cases (exact-final-range
end_of_track; FETCH_OK End Location past the requested group) gate the next 0.17 cut?Required, so it gates the cut.How should the follow-ups be tracked?
Backport #4653's fix for the flaky
moq-cliexport linger test torelease?Impact
Alternatives
Gating the cut on the edge-case fixes, rejected above.
Follow-ups
/quest/m0/release-22/README.md). 0.17.4 (chore: release #5332) shipped without FETCH.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code