Repository navigation
quest(m0): plan removing the WebSocket-to-QUIC upgrade - #5463
Conversation
The upgrade turns every WebSocket win on an epochless route into a Restart right after connecting. Plan its removal in m0, delete the m1 transport-upgrade epic, and fold the QUIC-wins race flake's remaining observation into it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 705f75a36f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| WebSocket hot path was removed on 2026-10-13, so a WebSocket session stays | ||
| on TCP for its lifetime.) |
There was a problem hiding this comment.
At this commit the WebSocket-to-QUIC upgrade is still implemented in rs/moq-tokio/src/connection.rs and client.rs; the new m0 quest is only the plan to delete it. Recording that it “was removed on 2026-10-13” therefore makes this quest's rationale and its claim about current session behavior false until the implementation lands. Describe the removal as decided or planned, or update this history in the implementation commit.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed. Fixed in ae45e3c: the note now says the removal was decided on 2026-10-13 and is being done by the m0 quest, and that a WebSocket session will stay on TCP.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary:
Public API: none in this PR. Wire: none. (Written by Claude Opus 5.5) |
Plans Keep the winning transport: a
moq-tokioconnection keeps whichever transport won thehttps://race, and the #4180 upgrade is removed.On an epochless route, which is the default for lite-06, the browser and the bindings, the upgrade is a
Restartright after connecting. Players re-resolve, re-fetch the catalog and reset their decoders. Nothing shows the upgrade helps outside CI's debug builds.Decisions (maintainer, 2026-10-13):
WEBSOCKET_WONmemo and document what clears it.moq_net::Session::setup()unless GOAWAY drain migration gates on it.Restartmoved to m1 (restart-followers), since drains and publisher replacement still send it.Tree changes:
transport-upgradeepic and its JS child.try_recv().Public API: none in this PR. The plan removes
Session::setup()(breaking). Wire: none.quest check: 475 documents ok.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.