Repository navigation
quest: plan the io_uring connection log, three flakes, and Biome on doc/demo - #5610
Conversation
…oc/demo Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ffee2881e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary:
Enabling auto-merge on the current head. (Written by Opus 5.5) |
Plans four maintainer-approved follow-ups from the 2026-10-15 merge batch. Quests only; nothing is implemented.
Quests
quest/m2/uring-connection-log.md(new): every relay accept path, io_uring included, logs a connection'sconn{id=N}span,negotiated, and close from one owner undermoq_relay::connection. Checked on main atde6c27302: the ring'sserve_connection(rs/moq-relay/src/uring.rs) bypassesConnection::run, logs undermoq_relay::uringwith no span, and drops a panicking supervise task without a close line. The root problem recorded is the duplicated admission and supervision; the logs are the visible drift. Ranked beside the other ring quests in m2, since Interop does not run the ring today.quest/m1/test-flakes-2/gains three children, and its Goal now covers CI and interop flakes, not only a loadedjust check:js-go-rewind.md: thejs -> gocell's "frame timestamp ... is below the previous group's start" (moq-mux consumer). Seen once locally on fix(relay): admit WebSocket sessions after SETUP #5546; not in the 13 failed Interop runs of 2026-10-15 or the 10-13 to 10-15 nightlies.wasm-ietf-read.md:ietf: reads a published broadcastfailed withread 0 whole groups in 8 attempts, want 2in WASM runs 38778431765 (test(interop): re-measure planned wire-compat breaks at each release #5577) and 38607947479 (quest/m0/ci/js-select). The log shows a ~500 ms stall, then a burst of groups that were all retired as old.cli-announced-connect.md:announced::tests::fails_when_the_session_endsfailed once locally on fix(cli): catch shutdown signals before serving #5575 because the fixture publisher's connect returnedTransportRace. Not in CI.quest/m2/biome-doc-demo.md(new): Biome coversdoc/anddemo/the way ci(js): run biome on test/ #5589 coveredtest/. Todaybun biome check doc demoreports one format error (doc/.vitepress/drafts.ts) and one warning that is a false positive (compactinCommunity.vueis used by the template).Not changed: the #5148 auth quests
#5148's branch already rewrites these quests to its
requests()model. It deletesconcurrent-renewal.md,enforcement-cursor.md, andrequest-token.md, and updatesjoin-revocation.md,request-auth-id.md,request-gate.md,request-update.md, the auth README, and the m3auth-request-lease.md,auth-token-fetch.md, andrequest-token-surfaces.md. Noscoped()reference is left on that branch. Editing the same files on main would only conflict with it, so they stay as they are here and change when #5148 merges.Decisions
The approved scope was applied with these recommended placements. The maintainer can still move any of them:
test-flakes-2✅ / a new flake epicPublic API: none. Wire: none.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)