Skip to content

quest: plan the io_uring connection log, three flakes, and Biome on doc/demo - #5610

Merged
kixelated merged 2 commits into
mainfrom
quest/plan-uring-log-flakes-biome
Oct 15, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/plan-uring-log-flakes-biome

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans four maintainer-approved follow-ups from the 2026-10-15 merge batch. Quests only; nothing is implemented.

Quests

  • quest/m2/uring-connection-log.md (new): every relay accept path, io_uring included, logs a connection's conn{id=N} span, negotiated, and close from one owner under moq_relay::connection. Checked on main at de6c27302: the ring's serve_connection (rs/moq-relay/src/uring.rs) bypasses Connection::run, logs under moq_relay::uring with no span, and drops a panicking supervise task without a close line. The root problem recorded is the duplicated admission and supervision; the logs are the visible drift. Ranked beside the other ring quests in m2, since Interop does not run the ring today.
  • quest/m1/test-flakes-2/ gains three children, and its Goal now covers CI and interop flakes, not only a loaded just check:
  • quest/m2/biome-doc-demo.md (new): Biome covers doc/ and demo/ the way ci(js): run biome on test/ #5589 covered test/. Today bun biome check doc demo reports one format error (doc/.vitepress/drafts.ts) and one warning that is a false positive (compact in Community.vue is used by the template).

Not changed: the #5148 auth quests

#5148's branch already rewrites these quests to its requests() model. It deletes concurrent-renewal.md, enforcement-cursor.md, and request-token.md, and updates join-revocation.md, request-auth-id.md, request-gate.md, request-update.md, the auth README, and the m3 auth-request-lease.md, auth-token-fetch.md, and request-token-surfaces.md. No scoped() reference is left on that branch. Editing the same files on main would only conflict with it, so they stay as they are here and change when #5148 merges.

Decisions

The approved scope was applied with these recommended placements. The maintainer can still move any of them:

Public API: none. Wire: none.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

…oc/demo

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b076142e-b966-49b4-89d9-2958bb485fa2
📥 Commits

Reviewing files that changed from the base of the PR and between de6c273 and 903200b.

📒 Files selected for processing: 7
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/cli-announced-connect.md
  • quest/m1/test-flakes-2/js-go-rewind.md
  • quest/m1/test-flakes-2/wasm-ietf-read.md
  • quest/m2/README.md
  • quest/m2/biome-doc-demo.md
  • quest/m2/uring-connection-log.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ffee2881e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m2/uring-connection-log.md Outdated
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T20:02:24.147544Z 4ffee28 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

Enabling auto-merge on the current head.

(Written by Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit b86d15c Oct 15, 2026
7 checks passed
@kixelated
kixelated deleted the quest/plan-uring-log-flakes-biome branch October 15, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant