Skip to content

quest(ci): record platform queue measurements - #5684

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/ci/platform-queue
Oct 18, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/ci/platform-queue

Conversation

@kixelated

@kixelated kixelated commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Updates quest/m0/ci/platform-queue.md with measurements of the merge-queue platform workflow (#5488). The gates stay unrequired: main has blocked the quest on Windows restart drill and macOS zero-RTT test, which fail in the queue today. No ruleset was changed.

Changes to the quest plan

  • Merge group shape (verified 2026-10-16): of 25 completed Platform merge_group runs, none ran more than one macOS and one Windows job, unrelated diffs skipped both, and main PRs report Platform scope, macOS, and Windows as skipped from app 15368.
  • Queue check timeout 120 minutes (was 90 in the plan): across 100 queue macOS jobs (2026-10-14 to 10-16), runner wait was p50 0.2, p90 33, max 83 minutes; wait plus run exceeded 90 minutes for 3 jobs and 120 for none. The jobs' own 90-minute timeout-minutes already bounds run time.
  • Nightly capacity: Nightly never overlapped a queue wait. The long waits came from the queue's own five concurrent builds plus release-PR and manually dispatched Platform runs, so no Nightly reservation; revisit the build limit if waits recur once the gates are required.

release still runs the pre-#5488 path-filtered workflow, so its ruleset change keeps waiting on the next cut, as the plan already says.

Public API / wire impact

None. Quest file only.

Suggested follow-ups

  • Re-measure queue macOS waits after mbx on R2 lands and the gates are required; lower max_entries_to_build only if long waits recur.

Checks: quest check passes. No workflow is touched.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 15, 2026 22:23
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The merge queue platform workflow (#5488) is verified on main: every merge
group runs at most one macOS and one Windows job, unrelated diffs skip both,
and main PRs report all three contexts as skipped. The main ruleset change is
a maintainer action listed in the PR. Release still runs the old
path-filtered workflow, so its ruleset change waits on a cut; track that as a
condition quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Quest outcome: the workflow side is verified on main; no ruleset changes were made. Merging requires the maintainer to first add Platform scope, macOS, and Windows (integration 15368) to main ruleset 2420853 and set the queue check timeout (recommend 120 min over the planned 90, since 3 of 100 sampled queue macOS jobs exceeded 90 min of wait plus run). The release ruleset waits on the next cut, tracked by quest/m0/ci/platform-release.md.

(Written by Claude Opus 5.5)

Main gave platform-queue.md two blockers (Windows restart drill, macOS
zero-RTT test), so the gates cannot be required yet. Keep the quest and
record the verified merge group shape, a 120-minute queue timeout, and
that Nightly did not cause the macOS contention. Drop platform-release.md;
the quest's plan already covers waiting for the release cut.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title quest: require the merge queue platform gates quest(ci): record platform queue measurements Oct 16, 2026
@kixelated
kixelated marked this pull request as ready for review October 16, 2026 18:10
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a017340a-9922-46b7-aaf7-b20f1c38f202
📥 Commits

Reviewing files that changed from the base of the PR and between e600679 and ca8acbf.

📒 Files selected for processing: 1
  • quest/m0/ci/platform-queue.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T18:13:22.649097Z ca8acbf Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: updates quest/m0/ci/platform-queue.md with measured merge-queue platform data. The planned queue check timeout goes from 90 to 120 minutes (3 of 100 queue macOS jobs went over 90 minutes of wait plus run, none over 120). Merge groups were verified to run at most one macOS and one Windows job. Nightly gets no capacity reservation because it never overlapped a queue wait. No rulesets or workflows change.

Review: Codex gave a thumbs-up on head ca8acbf with no findings. CI is green. A local merge of current main is clean and quest check passes. Main has since removed this quest's Required blockers, so it is ready for the maintainer's ruleset step.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 18, 2026
Merged via the queue into main with commit 83ca76f Oct 18, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/ci/platform-queue branch October 18, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant